Skip to content

Translate when to use grid Spanish #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2020
Merged

Translate when to use grid Spanish #381

merged 3 commits into from
Mar 28, 2020

Conversation

@jmartinezpoq
Copy link
Contributor

@jmartinezpoq jmartinezpoq commented Mar 28, 2020

Description

Add translation for when to use the grid page

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

harsha509
harsha509 reviewed Mar 28, 2020
View reviewed changes
harsha509
harsha509 requested changes Mar 28, 2020
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jmartinezpoq !

I've suggested one change can you please look into it.

Regards,
Harsha

@jmartinezpoq @harsha509
Update docs_source_files/content/grid/when_to_use_grid.es.md
e63e057 
Co-Authored-By: Sri Harsha <Harsha509@users.noreply.github.com>
@jmartinezpoq
Copy link
Contributor Author

jmartinezpoq commented Mar 28, 2020

Thank you @harsha509

harsha509
harsha509 approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jmartinezpoq !

@harsha509 harsha509 merged commit e81822a into SeleniumHQ:master Mar 28, 2020
@jmartinezpoq jmartinezpoq deleted the when_use_grid_spanish branch March 28, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha509 harsha509 harsha509 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmartinezpoq @harsha509