Skip to content

Conversation

@diemol
Copy link
Member

@diemol diemol commented Aug 16, 2020

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Adding env var to detect netlify deployments

Motivation and Context

It will allow to preview PRs by deploying them to Netlify

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@diemol diemol merged commit b19c135 into dev Aug 16, 2020
@diemol diemol deleted the netlify branch August 16, 2020 09:03
@diemol diemol restored the netlify branch August 16, 2020 09:03
@diemol diemol deleted the netlify branch August 16, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants