Skip to content

Browser navigation using JavaScript #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 5, 2019
Merged

Browser navigation using JavaScript #51

merged 9 commits into from
Nov 5, 2019

Conversation

@hiroksarker
Copy link
Contributor

@hiroksarker hiroksarker commented Oct 28, 2019

Browser navigation using JavaScript

@hiroksarker
Browser navigation using JavaScript
960e53c 
Browser navigation using JavaScript
diemol
diemol requested changes Oct 28, 2019
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the code example to the other translated languages?

@hiroksarker
Copy link
Contributor Author

hiroksarker commented Oct 28, 2019

@diemol Of course, Work is in progress.

@hiroksarker
Change Request - JavaScript Navigation
cad5964 
Change Request  - JavaScript Navigation
@hiroksarker
JavaScript Navigation (Build Issue)
e423f1b 
JavaScript Navigation (Build Issue)
@hiroksarker hiroksarker requested a review from diemol October 28, 2019 12:49
diemol
diemol requested changes Oct 28, 2019
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hiroksarker,

Please include this change in the following files as well:
docs_source_files/content/support_packages/browser_navigation.fr.md
docs_source_files/content/support_packages/browser_navigation.nl.md
docs_source_files/content/support_packages/browser_navigation.es.md
docs_source_files/content/support_packages/browser_navigation.ja.md
docs_source_files/content/support_packages/browser_navigation.zh-cn.md

These changes should be part of this PR as well. Thank you.

@hiroksarker hiroksarker requested a review from diemol October 29, 2019 03:07
@diemol
Copy link
Member

diemol commented Oct 29, 2019

@hiroksarker did you have a look at my previous comment?

@hiroksarker hiroksarker mentioned this pull request Oct 31, 2019
Closed
diemol
diemol approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiroksarker thanks for contributing, I completed the changes myself, the idea is to have all related code examples for all translated languages in the same pull request.
Please take that into account for future PRs.

@diemol diemol merged commit f3be1f1 into SeleniumHQ:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiroksarker @diemol