Skip to content

Conversation

@stibinator
Copy link

Added info for Chocolatey users on Windows. Should probably add Homebrew for mac and the major linux package managers, as these are a much simpler way of getting the binaries.

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Added info about how to use the Chocolatey package manager to install the binaries.

Motivation and Context

Because the instructions currently don't tell users how to easily download and install the drivers I was about to give up in disgust, when I thought to try chocolatey, and it was ridiculously easy. Using a package manager is by far the easiest way to install and maintain packages like this. Homebrew and dpkg / rpm /yum etc should be added too. That is if you want to reduce the friction for new users.

Types of changes

  • [* ] Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • [ *] I have read the contributing document.
  • [ *] I have used hugo to render the site/docs locally and I am sure it works.

Added info for Chocolatey users on Windows. Should probably add Homebrew for mac and the major linux package managers, as these are a much simpler way of getting the binaries.
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, @stibinator!
Overall, I think it is a good idea to add this, but please have a look at the comments I left.

### Chocolatey
On Windows systems the driver binaries can be installed individually, or as a collection using [chocolatey](https://chocolatey.org/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR should also include the package managers for macOS and Linux

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to add this, but I don't have access to mac or linux systems to check it on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To move forward with this, maybe you can leave the placeholders for the sections.

On Windows systems the driver binaries can be installed individually, or as a collection using [chocolatey](https://chocolatey.org/).
* To find the available drivers, use choco list:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid adding the commands here, we should link to their official page that shows how to use the packages, if we duplicate things here, they can get easily out of date.

@diemol
Copy link
Member

diemol commented Jan 4, 2021

@stibinator, please let us know if you'd like to continue with this PR.

@netlify
Copy link

netlify bot commented Jan 24, 2021

Deploy preview for jovial-austin-42fe02 ready!

Built with commit 988b5be

https://deploy-preview-547--jovial-austin-42fe02.netlify.app

@diemol
Copy link
Member

diemol commented Apr 30, 2021

This PR has gone stale, we will revisit when comments are addressed.

@diemol diemol closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants