-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update chrome_devtools.en.md add example charp #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add get console log example c-sharp
|
✔️ Deploy Preview for jovial-austin-42fe02 ready! 🔨 Explore the source changes: 5b31f9d 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/610967d926a3e200073c9730 😎 Browse the preview: https://deploy-preview-722--jovial-austin-42fe02.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @namilkimfree,
Thanks for the PR.
I have a couple of suggestions on this PR:
- Code looks good to me, but it can be a shorter code snippet than the code in PR
- Code needs to be changed in other translated pages too.
- You need to also sign the CLA in order to get this PR merged
docs_source_files/content/support_packages/chrome_devtools.en.md
Outdated
Show resolved
Hide resolved
Code changed to short.
add console.log event example C-Sharp
remove enter
Added console log event sample with c-sharp
Added console log event sample with c-sharp
Added console log event sample with c-sharp
|
Hi @namilkimfree , Could you please sign the CLA to get this merged! |
Hi @harsha509 I'm sorry, sign is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namilkimfree, we have updated our site, could you please update the files now in this location?
https://github.com/SeleniumHQ/seleniumhq.github.io/tree/dev/website_and_docs/content/documentation/support_packages
Then we can merge this. Thanks!
|
Hi @namilkimfree, Thanks for the PR. As the PR went stale. This PR is replaced with this commit ! |
add get console log example c-sharp
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist