Skip to content

Conversation

@namilkimfree
Copy link

@namilkimfree namilkimfree commented Jul 1, 2021

add get console log example c-sharp

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

add  get console log   example c-sharp
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jul 1, 2021

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 5b31f9d

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/610967d926a3e200073c9730

😎 Browse the preview: https://deploy-preview-722--jovial-austin-42fe02.netlify.app

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @namilkimfree,
Thanks for the PR.

I have a couple of suggestions on this PR:

  1. Code looks good to me, but it can be a shorter code snippet than the code in PR
  2. Code needs to be changed in other translated pages too.
  3. You need to also sign the CLA in order to get this PR merged

Code changed to short.
add console.log event example C-Sharp
Added console log event sample with c-sharp
Added console log event sample with c-sharp
Added console log event sample with c-sharp
@harsha509
Copy link
Member

Hi @namilkimfree ,

Could you please sign the CLA to get this merged!

@namilkimfree
Copy link
Author

Hi @namilkimfree ,

Could you please sign the CLA to get this merged!

Hi @harsha509

I'm sorry, sign is complete.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namilkimfree, we have updated our site, could you please update the files now in this location?
https://github.com/SeleniumHQ/seleniumhq.github.io/tree/dev/website_and_docs/content/documentation/support_packages

Then we can merge this. Thanks!

harsha509 added a commit that referenced this pull request Sep 3, 2021
selenium-ci added a commit that referenced this pull request Sep 3, 2021
@harsha509
Copy link
Member

Hi @namilkimfree,

Thanks for the PR.

As the PR went stale. This PR is replaced with this commit !

@harsha509 harsha509 closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants