Skip to content

Conversation

@mdmintz
Copy link
Contributor

@mdmintz mdmintz commented Dec 21, 2021

Selenium does not use log4j

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Selenium does not use log4j

Motivation and Context

Selenium does not use log4j

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Selenium does not use log4j
@netlify
Copy link

netlify bot commented Dec 21, 2021

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 0c0148a

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61c22fc8088a730007ab2333

😎 Browse the preview: https://deploy-preview-897--jovial-austin-42fe02.netlify.app/

@ddavison
Copy link
Member

I'm not sure it's worth noting what Selenium does not use. I anticipate if we start with this, we'll have a list of all of the software that we do not use that has a major exploit found.

Could you maybe provide more motivation and context? 🙏

@mdmintz
Copy link
Contributor Author

mdmintz commented Dec 21, 2021

@ddavison This is the context:

Slack___selenium-plc___selenium

@ddavison
Copy link
Member

@ddavison This is the context:

Slack___selenium-plc___selenium

I think we should be able to use the dismissible banner for this instance 🤔

I think this would be better than a blurb on the header. What do you think?

@mdmintz
Copy link
Contributor Author

mdmintz commented Dec 21, 2021

@ddavison Based on the code when the banner was last used (ebcafc8) the folder structure has changed significantly (there's no more site_source_files directory) and so I would only be guessing the new structure that you'd want for that, and that would likely involve a lot of back-and-forth PR questions and comments like this. I picked a reasonable alternative (the bold text is still noticeable) and since I imagine that this special message will only be up for about a month (at which point all major Selenium users concerned about Log4j would already understand that Selenium does not use it) then the styling of the message isn't too significant. After-all, this is a temporary message to begin with.

@ddavison
Copy link
Member

ddavison commented Dec 21, 2021

@ddavison Based on the code when the banner was last used (ebcafc8) the folder structure has changed significantly (there's no more site_source_files directory) and so I would only be guessing the new structure that you'd want for that, and that would likely involve a lot of back-and-forth PR questions and comments like this. I picked a reasonable alternative (the bold text is still noticeable) and since I imagine that this special message will only be up for about a month (at which point all major Selenium users concerned about Log4j would already understand that Selenium does not use it) then the styling of the message isn't too significant. After-all, this is a temporary message to begin with.

Screen Shot 2021-12-21 at 15 59 19

Yeah, looks like we should create a dismissible-banner shortcode. I have a local WIP I can upload.

@mdmintz
Copy link
Contributor Author

mdmintz commented Dec 21, 2021

@ddavison That works. Looks like you already have the code for the dismissible banner.

@ddavison ddavison mentioned this pull request Dec 21, 2021
4 tasks
@ddavison
Copy link
Member

@ddavison That works. Looks like you already have the code for the dismissible banner.

Yeah, the code was already there, just had to adapt it quickly to Hugo 🙃 . You're simple solution worked perfectly! This is just a more long-term solution that enables other things like this in the future 🙏

Would you review #898 ?

@mdmintz
Copy link
Contributor Author

mdmintz commented Dec 21, 2021

@ddavison #898 Looks good. I'm not an authorized reviewer, but I approve your changes.

@mdmintz
Copy link
Contributor Author

mdmintz commented Dec 21, 2021

Closing this in favor of #898

@mdmintz mdmintz closed this Dec 21, 2021
@mdmintz mdmintz deleted the patch-1 branch January 7, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants