[AMD] dsv4-fp4-mi355x-atom: latest atom-dev image + opt recipe#2325
[AMD] dsv4-fp4-mi355x-atom: latest atom-dev image + opt recipe#2325zufayu wants to merge 5 commits into
Conversation
- image: nightly_202606161823 -> nightly_202607231538 (latest atom-dev) - recipe (dsv4_fp4_mi355x_atom.sh): max_num_seqs=conc + TBO on dp-attn cells at conc>=64 (was ATOM-default max_num_seqs + TBO per-scenario gate 256/1024) - add 1k1k scenario (was 8k1k only; mirrors prior grid) - 8k1k grid: align AMD dev sweep (run 20260723) + tp8 dp-off low-conc redundancy Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@seungrokj @chunfangamd — this PR re-sweeps
Could you please review and add the |
max_req=conc is a mid/high-concurrency optimization. At very low conc (e.g. c2) the ATOM default is on-par or ~4% better, so only set --max-num-seqs=conc for conc>=64 (matches the TBO gate). High conc still gets it (removes the cap). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Correction on the recipe (pushed): Dev finding: |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Dropped the 1k/1k scenario — this sweep is 8k/1k only now. Config keeps just the 8192/1024 grid. |
|
also would yall like to submit ATOM dsv4 towards the agentic coding scenario, seems impactful and more real world to spend time on that @chunfangamd @zufayu |
dp-attention keeps a full KV pool per rank, so the large default max_num_seqs OOMs even at low conc (c16/c32). Set max_req=conc for every dp-on cell; dp-off low conc still uses the ATOM default. TBO gate unchanged (conc>=64).
The agentic scenarios are run by other dedicated AMD developers who push their branches upstream — I'm on the dsv4-atom line and need the same access. |
|
Hi @functionstackx — could you add zufayu as a collaborator? This PR is from a fork, so its sweep gets no secrets and fails at checkout (Input required and not supplied: token). I'm on the dsv4-atom line and need write access to push my branch and trigger the sweep. Thanks! PS: Two-factor authentication Configured |
|
Superseded by #2327 — the branch is now in upstream ( |
What
Re-sweep
dsv4-fp4-mi355x-atom(DeepSeek-V4-Pro FP4, MI355X) on the latest atom-dev image with an optimized recipe.Changes
nightly_202606161823→nightly_202607231538(latest atom-dev)dsv4_fp4_mi355x_atom.sh):--max-num-seqs "$CONC"(was ATOM default) — so high concurrency (1024/2048) isn't capped by max_num_seqsconc>=64(was per-scenario gate 256/1024)Why the recipe change
AMD internal dev benchmarking (atom-dev image b31cc35) shows this recipe beats the prior default:
max_num_seqs=concremoves the high-concurrency throughput capconc>=64from measured crossover (no measurable TBO gain below conc 64 on 8k/1k)Note for reviewers
Needs the
full-sweep-fail-fastlabel to run the sweep on the new image.RANDOM_RANGE_RATIOstays at the repo default (0.8), matching the dev runs.Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com