fix(agentx): adopt additive AIPerf main warmup - #2415
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
Claude finished @cquil11's task in 4m 6s —— View job Review of PR #2415
SummaryThe core change is sound: One 🟡 warning posted inline (benchmarks/benchmark_lib.sh:1745): the removed Notes on verification scope: this environment couldn't reach the No blocking issues found. |
cquil11
added
agentx-fast
ChatGPT Codex Connector
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30495403097 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30495544822 |
1 similar comment
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30495544822 |
786f856 to
9543505
Compare
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30502957473 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30505223590 |
9543505 to
aac2334
Compare
cquil11
removed
sweep-enabled
agentx-fast
cquil11
changed the title
Pin the shared AIPerf submodule to the synchronized main revision with additive per-lane warmup after mandatory primers while retaining timing-faithful spread phase starts. Align the workflow documentation with the request-count fast preset. 中文：将共享 AIPerf 子模块固定到已同步的 main 版本，在必需预热请求之后执行额外的逐 lane 预热，并保留符合轨迹时序的分散阶段启动。同步更新工作流文档，使其准确描述基于请求数量的快速预设。
aac2334 to
3f788b0
Compare
…armup Run 30511545046 tried lazy alone and is uninterpretable. It landed just after #2415 swapped the agentic warmup from --agentic-cache-warmup-duration 600 to --warmup-requests-per-lane 10 (benchmark_lib.sh:1793, plus a new utils/aiperf pin), so it moved two variables at once. Its "0 successful / 49 total, OSL=1" is the new warmup's one-token lane primers, not a lazy-offload symptom -- the cell never left warmup. That also invalidates the seven earlier fp8+offload failures as baselines: all of them ran the old time-based warmup. So run the eager control at c8 on the SAME warmup as lazy, in one dispatch, and compare those two only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Pin the shared AIPerf submodule to the synchronized main revision with additive per-lane warmup after mandatory primers while retaining timing-faithful spread phase starts. Align the workflow documentation with the request-count fast preset. 中文：将共享 AIPerf 子模块固定到已同步的 main 版本，在必需预热请求之后执行额外的逐 lane 预热，并保留符合轨迹时序的分散阶段启动。同步更新工作流文档，使其准确描述基于请求数量的快速预设。
…armup Run 30511545046 tried lazy alone and is uninterpretable. It landed just after #2415 swapped the agentic warmup from --agentic-cache-warmup-duration 600 to --warmup-requests-per-lane 10 (benchmark_lib.sh:1793, plus a new utils/aiperf pin), so it moved two variables at once. Its "0 successful / 49 total, OSL=1" is the new warmup's one-token lane primers, not a lazy-offload symptom -- the cell never left warmup. That also invalidates the seven earlier fp8+offload failures as baselines: all of them ran the old time-based warmup. So run the eager control at c8 on the SAME warmup as lazy, in one dispatch, and compare those two only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 participant
Summary
be758d62on synchronizedSemiAnalysisAI/aiperfmain.agentx-fast, use one additional warmup request per lane and a 20-minute profile.--burst-phase-starts.The 10-second cap applies only to whole-system idle periods. Recorded per-trace end-to-start delays remain intact.
Validation
python -m pytest utils/matrix_logic/ utils/test_process_changelog.py -q— 238 passedThe workflow's unrelated full SWE-bench eval was externally canceled; all AgentX throughput jobs completed successfully.