feat(minimaxm3-fp4-b300-dynamo-vllm-mtp): bump vLLM nightly to 5e35a6f4, enable cutlass MSA decode / 更新 minimaxm3-fp4-b300-dynamo-vllm-mtp vLLM 镜像至 5e35a6f4,启用 cutlass MSA 解码后端 - #2471
Conversation
…f4, enable cutlass MSA decode backend 中文:将 minimaxm3-fp4-b300-dynamo-vllm-mtp vLLM 镜像升级至 nightly-5e35a6f4f9bbc217c599692157ca985c894373f7,更新 B300 FP4 MTP recipe YAML(排除 legacy-dep4 专用配方),并启用 VLLM_MINIMAX_M3_MSA_DECODE_BACKEND=cutlass Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
… bump entry Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
LGTM — straightforward vLLM nightly bump and MSA decode backend flag for the minimax-m3 B300 FP4 MTP recipes.
What was reviewed: verified the container tag bump (4080263b → 5e35a6f4) and new VLLM_MINIMAX_M3_MSA_DECODE_BACKEND: cutlass env var are applied consistently across all 5 recipe YAMLs, master config, and changelog; confirmed the intentionally-excluded 2p1d-dep2-dep4 recipe (pinned to the legacy-dep4 image) was correctly left untouched.
Extended reasoning...
Overview
This PR bumps the vLLM nightly image tag for the minimaxm3-fp4-b300-dynamo-vllm-mtp config from nightly-4080263b to nightly-5e35a6f4 and adds VLLM_MINIMAX_M3_MSA_DECODE_BACKEND=cutlass to the prefill/decode environments across 5 B300 FP4 8k1k MTP recipe YAMLs, plus the corresponding configs/nvidia-master.yaml entry and a perf-changelog.yaml record. This follows the repo's standard nightly-image-bump pattern used for other model configs.
Security risks
None. These are benchmark recipe configs (container tags and env vars) with no code, auth, or credential changes.
Level of scrutiny
Low — this is a mechanical, repeated edit (image tag + one env var) applied identically across a known set of files, consistent with prior nightly-bump PRs in this repo. The PR correctly excludes the 2p1d-dep2-dep4 recipe, which pins a different (legacy) image, matching the stated intent in the description.
Other factors
No bugs were found by the bug hunting system. I cross-checked that all 5 modified recipe files, the master config, and the changelog are internally consistent, and that the excluded legacy recipe was correctly left alone. The PR is gated on a full benchmark sweep (full-sweep-fail-fast label) before merge, which will catch any functional regressions from the image bump itself.
…rom prefill (no cudagraph) 中文:从预填充环境中移除 VLLM_MINIMAX_M3_MSA_DECODE_BACKEND=cutlass(预填充工作进程不使用 CUDA graph)
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30821722120 |
…or cutlass MSA decode, not env var 中文:将 decode_environment 中的 VLLM_MINIMAX_M3_MSA_DECODE_BACKEND 替换为解码侧 attention-config JSON 中的 minimax_m3_msa_decode_backend 字段
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30824007160 |
…P recipe YAMLs 中文:在 B300 FP4 MTP recipe YAML 的预填充与解码配置中补充 kv-cache-dtype: fp8 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…300-dynamo-vllm-mtp-nightly-5e35a6f4 # Conflicts: # perf-changelog.yaml
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30828244671 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30838377466 |
1 similar comment
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30838377466 |
|
/reuse-sweep-run |
kedarpotdar-nv
left a comment
There was a problem hiding this comment.
As a PR reviewer and CODEOWNER, I have reviewed this and have:
- Verified that as of the moment of typing this, this is the latest version of PR_REVIEW_CHECKLIST.md
- Verified that the general code quality meets the InferenceX standard and does not make the code quality any worse.
- Verified that this PR has passed PR validation. Please link to GitHub Action workflow that shows this.
- Verified that this PR passes evals. Please link to GitHub Action workflow that shows this.
- Verified that speculative decoding PRs uses chat templates to align the AL distribution to real world
- For agentic workloads: verified that speculative-decoding configs (EAGLE / MTP / draft models) run with simulated synthetic acceptance, with the acceptance-length value taken from the committed golden AL curve in golden_al_distribution/ for that model, thinking mode, and draft length. A submission may choose any supported draft length, but it may not substitute a different acceptance target.
- Verified against the current MODELS.md that this PR does not submit a deprecated model, scenario, or model-scenario combination.
- Verified that the model architecture isn't changed with benchmark hacks like using --hf-overrides to skipping indexer for every x layers on models that don't natively support this. As a general rule, we won't accept optimizations that reduces the number of model architecture FLOPs. Anything that makes that same computation run faster is fair game; FLOPs at lower precisions is fine, given that the config passes private evals. As an general north star princple, we should only use optimizations which is used in production by customers that care about accuracy
- If an company claims that they support vLLM/SGLang as first class LLM inference engines on their hardware, I have verified that the respective vLLM submission made using upstream https://hub.docker.com/u/vllm docker repo, upstream SGLang https://hub.docker.com/u/lmsysorg docker repo. The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet as supported by vLLM/SGLang community maintainers
- If an company claims that they support vLLM/SGLang as first class upstream in-tree LLM inference engines on their hardware, I have have verified that the respective vLLM/SGLang submission has been made before additional frameworks (TRT-LLM, ATOM, etc.). The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet.
- Verified that every single-node vLLM/SGLang recipe in this PR is documented in the official vLLM recipes and/or the SGLang cookbook:
- I linked the corresponding upstream PR in the vLLM recipe repo or SGLang repo and verified that it is MERGED before this InferenceX PR merges. An opened, draft, or closed-without-merge upstream PR does not satisfy this requirement. If the matching recipe was already published, I linked the published recipe/cookbook page in the additional detail section below.
- Verified that this PR does not patch the inference engine or serving stack — the pinned image must run as shipped. This covers .patch files / git apply / patch, inline patches embedded in benchmark scripts (e.g. a python3/sed heredoc that rewrites installed engine sources before serving), in-place edits of site-packages, monkey-patching, overwriting container files, and installing forked/rebuilt engine wheels on top of the pinned image. The only exception is a patch covered by a filled-out waiver at docs/waiver/
<PR_NUMBER>.md— named after the PR that introduces the patch and filed in that same PR, stating what is patched, why the unmodified upstream image cannot run this benchmark, the upstream PR/issue link, and the removal plan — which I have linked below in the additional detail section. - If any of the above criteria cannot reasonably be satisfied, I have provided additional reasoning below.
Additional detail section:
- Validation and evals: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/30838377466
- Speculative decoding uses chat templates in all five updated multi-node recipes.
- Upstream recipe check is N/A because this PR changes only disaggregated multi-node recipes.
- Uses the upstream
vllm/vllm-openaiimage; no serving-stack patches or model-architecture overrides are introduced. - Authorized sweep reuse: #2471 (comment)
Signed: kedarpotdar-nv
❌❌❌ REJECTED ❌❌❌@kedarpotdar-nv — blocking: every benchmark config this PR updates is the MiniMax-M3 Single-turn 8k1k scenario, which MODELS.md deprecates after 2026-08-03; the review date is 2026-08-04. A fresh sign-off cannot fix this — the submission targets a deprecated model-scenario combination. ✅ Check 0 (CODEOWNER): PASS — |
中文:将 main 合并到 PR 2471 分支,并保留该 PR 的性能变更日志条目。
…f4, enable cutlass MSA decode / 更新 minimaxm3-fp4-b300-dynamo-vllm-mtp vLLM 镜像至 5e35a6f4,启用 cutlass MSA 解码后端 (SemiAnalysisAI#2471) * feat(minimaxm3-fp4-b300-dynamo-vllm-mtp): bump vLLM nightly to 5e35a6f4, enable cutlass MSA decode backend 中文:将 minimaxm3-fp4-b300-dynamo-vllm-mtp vLLM 镜像升级至 nightly-5e35a6f4f9bbc217c599692157ca985c894373f7,更新 B300 FP4 MTP recipe YAML(排除 legacy-dep4 专用配方),并启用 VLLM_MINIMAX_M3_MSA_DECODE_BACKEND=cutlass Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * chore(perf-changelog): add minimaxm3-fp4-b300-dynamo-vllm-mtp nightly bump entry Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * fix(minimaxm3-fp4-b300-dynamo-vllm-mtp): remove cutlass MSA env var from prefill (no cudagraph) 中文:从预填充环境中移除 VLLM_MINIMAX_M3_MSA_DECODE_BACKEND=cutlass(预填充工作进程不使用 CUDA graph) * fix(minimaxm3-fp4-b300-dynamo-vllm-mtp): use attention_config field for cutlass MSA decode, not env var 中文:将 decode_environment 中的 VLLM_MINIMAX_M3_MSA_DECODE_BACKEND 替换为解码侧 attention-config JSON 中的 minimax_m3_msa_decode_backend 字段 * fix(minimaxm3-fp4-b300-dynamo-vllm-mtp): add kv-cache-dtype fp8 to MTP recipe YAMLs 中文:在 B300 FP4 MTP recipe YAML 的预填充与解码配置中补充 kv-cache-dtype: fp8 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: adibarra <93070681+adibarra@users.noreply.github.com>
Summary
minimaxm3-fp4-b300-dynamo-vllm-mtpvLLM image tonightly-5e35a6f4f9bbc217c599692157ca985c894373f7(contains fixed-len MiniMax-M3 fix)model.containerand addVLLM_MINIMAX_M3_MSA_DECODE_BACKEND=cutlassto prefill and decode environments2p1d-dep2-dep4-eagle3-8k1k.yamlintentionally NOT updated (used byminimaxm3-fp4-b300-dynamo-vllm-mtp-legacy-dep4which pins a different image)Test plan
full-sweep-fail-fastlabel runs green中文说明
minimaxm3-fp4-b300-dynamo-vllm-mtpvLLM 镜像升级至nightly-5e35a6f4f9bbc217c599692157ca985c894373f7model.container,并在预填充与解码环境中添加VLLM_MINIMAX_M3_MSA_DECODE_BACKEND=cutlass2p1d-dep2-dep4-eagle3-8k1k.yaml有意保留不变(由minimaxm3-fp4-b300-dynamo-vllm-mtp-legacy-dep4使用,该配置固定使用不同镜像)🤖 Generated with Claude Code