Skip to content

[AMD][MI35X] Bump Qwen3.5 MXFP4 MI355X SGLang single-node image to v0.5.17 - #2640

Open
yichiche wants to merge 2 commits into
mainfrom
amd/qwen3.5-fp4-mi355x-sglang-v0.5.17
Open

[AMD][MI35X] Bump Qwen3.5 MXFP4 MI355X SGLang single-node image to v0.5.17#2640
yichiche wants to merge 2 commits into
mainfrom
amd/qwen3.5-fp4-mi355x-sglang-v0.5.17

Conversation

@yichiche

Copy link
Copy Markdown
Collaborator

Motivation

qwen3.5-fp4-mi355x-sglang and qwen3.5-fp4-mi355x-sglang-mtp are still pinned to lmsysorg/sglang-rocm:v0.5.16-rocm720-mi35x-20260730, which is roughly three weeks behind the current SGLang ROCm nightly. This bumps both single-node MI355X Qwen3.5 MXFP4 arms to the latest v0.5.17 mi35x image so the benchmark matrix reflects current upstream SGLang + aiter performance on MI355X.

Modifications

Bump the image: value for both config keys in configs/amd-master.yaml from lmsysorg/sglang-rocm:v0.5.16-rocm720-mi35x-20260730 to lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260817. No other config fields change — model, runner, TP/EP search space, and concurrency ranges are untouched.

Append the corresponding trigger entry to perf-changelog.yaml (append-only, at the end of the file) covering both config keys.

Benchmark scripts under benchmarks/single_node/fixed_seq_len/ are unchanged; this is a plain image bump.

Accuracy Tests

No accuracy-affecting logic changes in this repo — the change is limited to the container tag and the changelog trigger. Model correctness is covered by the upstream SGLang release validation for the v0.5.17 ROCm image.

Benchmarking

Repo validation was run locally:

  • python -m pytest utils/matrix_logic/ -q → 231 passed.
  • python utils/matrix_logic/generate_sweep_configs.py full-sweep --config-files configs/amd-master.yaml --model-prefix qwen3.5 --precision fp4 --runner-type mi355x emits the new tag on both arms: 10 generated configs with spec-decoding: none and 9 with spec-decoding: mtp, all referencing lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260817.

End-to-end MI355X throughput/latency numbers will come from the sweep triggered on this PR (full-sweep-fail-fast).

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@yichiche
yichiche force-pushed the amd/qwen3.5-fp4-mi355x-sglang-v0.5.17 branch from dfab028 to ff174eb Compare August 18, 2026 02:43
Comment thread perf-changelog.yaml
@github-actions

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@yichiche
yichiche force-pushed the amd/qwen3.5-fp4-mi355x-sglang-v0.5.17 branch from 090eb36 to 0ffaead Compare August 19, 2026 00:54
@yichiche
yichiche force-pushed the amd/qwen3.5-fp4-mi355x-sglang-v0.5.17 branch from 0ffaead to 7c92949 Compare August 19, 2026 00:56
@github-actions

This comment was marked as off-topic.

@yichiche
yichiche force-pushed the amd/qwen3.5-fp4-mi355x-sglang-v0.5.17 branch from 7c92949 to 2a47c0a Compare August 19, 2026 03:35
@github-actions

Copy link
Copy Markdown
Contributor

@yichiche

Copy link
Copy Markdown
Collaborator Author

Cookbook: sgl-project/sglang#35445

@github-actions

Copy link
Copy Markdown
Contributor

yichiche added a commit that referenced this pull request Aug 19, 2026
…m3 KV cache

Match the fp8_e4m3 KV cache that #2640 applies to the fixed-seq-len arms. The other MTP tunings from that PR are already present in the agentic script (mamba ssm dtype, 32768-token prefill/chunked prefill, tokenizer workers) or are deliberately different for long-running trace replay (scheduler-recv-interval 30, stream-interval 50).
@github-actions

Copy link
Copy Markdown
Contributor

functionstackx added a commit that referenced this pull request Aug 20, 2026
…-20260818 (#2677)

* [AMD][MI35X] Bump Qwen3.5 MXFP4 MI355X SGLang AgentX image to v0.5.17-20260818

Bump the qwen3.5-fp4-mi355x-sglang-agentic-mtp image from lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260811 to lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260818 and append the matching agentic-coding perf-changelog trigger.

* [AMD][MI35X] Point Qwen3.5 AgentX changelog entry to PR #2677

* [AMD][MI35X] Serve the Qwen3.5 MXFP4 MI355X AgentX arm with an fp8_e4m3 KV cache

Match the fp8_e4m3 KV cache that #2640 applies to the fixed-seq-len arms. The other MTP tunings from that PR are already present in the agentic script (mamba ssm dtype, 32768-token prefill/chunked prefill, tokenizer workers) or are deliberately different for long-running trace replay (scheduler-recv-interval 30, stream-interval 50).

* [AMD][MI35X] Restore the trailing newline in perf-changelog.yaml

The merge of main into this branch left perf-changelog.yaml without a final newline, which check-changelog rejects.

---------

Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com>
….5.17

Bump qwen3.5-fp4-mi355x-sglang and qwen3.5-fp4-mi355x-sglang-mtp from lmsysorg/sglang-rocm:v0.5.16-rocm720-mi35x-20260730 to lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260818, serve both arms with an fp8_e4m3 KV cache, and append the matching perf-changelog trigger.
@yichiche
yichiche force-pushed the amd/qwen3.5-fp4-mi355x-sglang-v0.5.17 branch from 79083bc to bfddbcf Compare August 20, 2026 12:05
@github-actions

Copy link
Copy Markdown
Contributor

…X MTP arm

Add --disable-shared-experts-fusion to qwen3.5_fp4_mi355x_mtp.sh. The non-MTP arm is unchanged.
@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant