Skip to content

Refresh DeepSeek V4 GB300 TRT-LLM AgentX metrics - #2774

Merged
cquil11 merged 11 commits into
mainfrom
agent/refresh-dsv4-gb300-trt-metrics
Sep 1, 2026
Merged

Refresh DeepSeek V4 GB300 TRT-LLM AgentX metrics#2774
cquil11 merged 11 commits into
mainfrom
agent/refresh-dsv4-gb300-trt-metrics

Conversation

@cquil11

@cquil11 cquil11 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Refresh DeepSeek V4 GB300 AgentX to collect TensorRT-LLM Prometheus metrics.
  • Use the pinned Dynamo fork for metrics collection with KV-event publishing disabled.
  • Preserve the existing TensorRT-LLM image and serving settings; validate KV-cache utilization in the collected metrics.

Upstream feature request: ai-dynamo/dynamo#14121


Note

Low Risk
Benchmark and changelog YAML only; no application or serving code paths change.

Overview
Refreshes six DeepSeek V4 Pro GB300 disaggregated Dynamo+TensorRT-LLM AgentX Slurm recipes so reruns can collect TensorRT-LLM server metrics (including KV-cache utilization), aligned with the prior GLM AgentX metrics refresh.

Dynamo is pinned by git hash (2cbbdc86…) instead of the dev wheel / identity.frameworks.dynamo version. Prefill and decode both set enable_iter_perf_stats: true. Frontend and benchmark env move KV_OFFLOADING from none to dram. The agentic client adds AIPERF_REQUIRED_SERVER_METRIC_PREFIX: trtllm_kv_cache_utilization so AIPerf fails fast if expected Prometheus metrics are missing. perf-changelog.yaml records the dsv4-fp4-gb300-dynamo-trt-agentx agentic-coding refresh for this PR.

Reviewed by Cursor Bugbot for commit a00b074. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@@ -88,7 +88,8 @@ backend:
moe_expert_parallel_size: 8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Recipe modification (metrics/telemetry toggles across 6 GB300 DSv4 recipes) is missing the required perf-changelog.yaml entry mandated by AGENTS.md's non-negotiable invariant. [also at: perf-changelog.yaml:1 - Missing required perf-changelog.yaml entry for this recipe-modifying PR, violating AGENTS.md's non-negotiable benchmark…]

Extended reasoning...

AGENTS.md states every recipe addition or modification requires a new perf-changelog.yaml entry, and CONTRIBUTING.md restates this as a MUST; git diff on perf-changelog.yaml is empty for this change. After merge, these 6 recipe files diverge from their changelog history with no traceable rationale for the return_perf_metrics/enable_iter_perf_stats/publish_events_and_metrics/AIPERF_REQUIRED_SERVER_METRIC_PREFIX changes, breaking the append-only audit trail reviewers rely on to correlate recipe behavior changes with PRs.

Verification: Severity: normal (this PR triggers a non-negotiable, merge-gating invariant that it fails to satisfy). The diff (git diff 0ec742a2ba45a0cbc3be183b7697ebb90f35439b HEAD --stat) modifies exactly 6 recipe YAMLs under benchmarks/multi_node/srt-slurm-recipes/trtllm/deepseek-v4/agentx-gb300-20260811/ (36 insertions, 18 deletions) and touches nothing else. Confirmed the specific edits at 1p1d line…

@github-actions

Copy link
Copy Markdown
Contributor

Comment thread utils/agentic/aggregation/backends/trtllm.py
Comment thread utils/agentic/aggregation/backends/trtllm.py
@github-actions

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2986619. Configure here.

Comment thread benchmarks/multi_node/agentic_srt.sh
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

@cquil11
cquil11 force-pushed the agent/refresh-dsv4-gb300-trt-metrics branch from 4473e70 to 4468ccc Compare August 31, 2026 17:13
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@cquil11 staging run 33418433573. InferenceX-app staging workflow is now running. Existing staged runs will be preserved; this comment will be updated when staging completes.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@cquil11 staged run 33418433573: https://inferencemax-app-git-staging-semianalysisai.vercel.app/inference?i_dates=2026-08-31~r33418433573

This run remains available across future /stage-results requests. Staging the same run ID again updates its staged data. Staging workflow

@cquil11

cquil11 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/stage-results 33418433573

@cquil11

cquil11 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/reuse-sweep-run 33418433573

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@cquil11 staging run 33418433573. InferenceX-app staging workflow is now running. Existing staged runs will be preserved; this comment will be updated when staging completes.

@cquil11

cquil11 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/reuse-sweep-run 33418433573

@cquil11
cquil11 force-pushed the agent/refresh-dsv4-gb300-trt-metrics branch from ade38fc to 4468ccc Compare September 1, 2026 20:27
@cquil11

cquil11 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/reuse-sweep-run

@cquil11

cquil11 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/reuse-sweep-run 33418433573

@cquil11
cquil11 merged commit 5ecf6fd into main Sep 1, 2026
29 checks passed
@cquil11
cquil11 deleted the agent/refresh-dsv4-gb300-trt-metrics branch September 1, 2026 21:35
karverma-amd added a commit that referenced this pull request Sep 2, 2026
main appended five entries (#2770-#2774, #2790) at the end of the changelog
while this branch appended the DSv4 MI355X entry, so the two collided on the
same trailing lines. All are kept, upstream's first.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant