feat: add protocol-evidence verification foundation - #109
Merged
chrisuthe merged 1 commit intoSep 4, 2026
Conversation
Introduce a protocol-evidence-based verification mode for conformance scenarios so we can assert on Sendspin protocol compliance (hello negotiation, role capability advertisement, stream setup handshake, etc.) rather than only on rendered audio/media correctness. - src/conformance/protocol.py: defines protocol assertion IDs and protocol_evidence_failure() to check adapter summaries against them. - src/conformance/models.py: ScenarioSpec gains verification_mode support for 'protocol' and a protocol_assertions field. - src/conformance/scenarios.py: registers the new baseline protocol scenario. - src/conformance/runner.py: wires the 'protocol' verification_mode into _compare_summaries(). - README.md / adapters/README.md: document the protocol-evidence contract adapters must uphold. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chrisuthe
force-pushed
the
pr1-protocol-evidence-foundation
branch
from
September 4, 2026 18:41
f63e1d0 to
b6e0b7d
Compare
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We are migrating the conformance harness to test actual Sendspin protocol compliance (hello negotiation, role capability advertisement, stream-setup handshake, etc.) rather than only testing rendered audio/media correctness. This is the first, foundational PR in that migration; it introduces the verification machinery without changing any existing scenario behavior.
What
src/conformance/protocol.py(new): defines protocol assertion IDs andprotocol_evidence_failure(), which checks adapter summaries against a list of required assertions.src/conformance/models.py:ScenarioSpecgains a"protocol"verification_modeand aprotocol_assertionsfield.src/conformance/scenarios.py: registers a new baseline protocol scenario definition.src/conformance/runner.py: wires the"protocol"verification mode into_compare_summaries().README.md/adapters/README.md: document the protocol-evidence contract adapters must uphold going forward.This PR does not yet implement protocol-evidence emission in any adapter — that is deliberately split into follow-up PRs per implementation (starting with aiosendspin) so this stays reviewable.
Testing
python -m compileall src scripts