Enable client-initiated stream/request-format scenarios for sendspin-jvm#97
Merged
Merged
Conversation
sendspin-jvm's SendSpinClient now implements requestPlayerFormat() (Sendspin/sendspin-jvm#27), so the client role can drive the client-initiated-request-format-pcm/-flac scenarios that were previously gated purely on the static supports_request_format flag. Wires the JVM adapter to advertise two formats in client/hello, wait for the first stream/start, call requestPlayerFormat with the second format, and record the resulting renegotiation for the harness to verify against the re-emitted stream/start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SendSpinClientnow implementsrequestPlayerFormat()(Sendspin/sendspin-jvm#27), so flipsupports_request_format=Trueon its clientRoleSpec— this was the only thing gatingclient-initiated-request-format-pcm/-flacto "skipped" for sendspin-jvm.adapters/sendspin-jvm/client) to actually drive the two renegotiation scenarios, mirroring the sendspin-rs adapter'srun_request_format_client: advertise two formats inclient/hello, wait for the firststream/start, callrequestPlayerFormatwith the second format, then wait for the server to re-emitstream/startand recordstream_start_count/requested/initial_format/final_formatin the summary for_compare_renegotiation_summariesto verify.Test plan
python -m compileall src scriptsgit diff --checksendspin-jvmcheckout with PR [Spec coverage] Player role: server/command, static_delay_ms, chunk timestamps, 24-bit PCM, pre-stream binary rejection #27 mergedconformance run --from aiosendspin --to sendspin-jvmlocally end-to-end (aiosendspin server + real JVM client over a socket): both new scenarios pass —client-initiated-request-format-pcm :: Renegotiated pcm/8000Hz/24bit/1ch -> pcm/8000Hz/16bit/1chclient-initiated-request-format-flac :: Renegotiated pcm/8000Hz/16bit/1ch -> flac/8000Hz/16bit/1chconformance reportrenders cleanly against the resulting results dir🤖 Generated with Claude Code