Upgrade sendspin-js SDK from v2.0.5 to v3.0.0 - #212
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the web UI’s dynamically imported @sendspin/sendspin-js dependency to the new major release (v3.0.0) via unpkg, keeping the browser-side player integration on the latest SDK line.
Changes:
- Bumped the unpkg module import URL for
@sendspin/sendspin-jsfromv2.0.5tov3.0.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
646
to
648
| const sdkImport = import( | ||
| "https://unpkg.com/@sendspin/sendspin-js@2.0.5/dist/index.js?module", | ||
| "https://unpkg.com/@sendspin/sendspin-js@3.0.0/dist/index.js?module", | ||
| ); |
There was a problem hiding this comment.
The app dynamically imports the SDK from unpkg at runtime. This creates a production dependency on a third-party CDN (availability) and increases supply-chain risk for a core module. Consider vendoring/self-hosting the SDK (or bundling it in your build pipeline) so the app is not blocked by unpkg or an upstream artifact change.
selleronom
pushed a commit
to selleronom/sendspin-cli
that referenced
this pull request
Apr 15, 2026
## Summary Updates the sendspin-js SDK dependency to the latest major version (v3.0.0) in the web application. ## Key Changes - Updated SDK import URL from `@sendspin/sendspin-js@2.0.5` to `@sendspin/sendspin-js@3.0.0` ## Implementation Details The SDK is dynamically imported via unpkg CDN in the web app initialization. This upgrade to v3.0.0 brings the application to the latest major version of the sendspin-js library, which may include breaking changes, new features, or improvements. Users should verify that the application functionality remains intact with the new SDK version. https://claude.ai/code/session_01AxTjrk8DnF21ZiEsX2VKA5 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the sendspin-js SDK dependency to the latest major version (v3.0.0) in the web application.
Key Changes
@sendspin/sendspin-js@2.0.5to@sendspin/sendspin-js@3.0.0Implementation Details
The SDK is dynamically imported via unpkg CDN in the web app initialization. This upgrade to v3.0.0 brings the application to the latest major version of the sendspin-js library, which may include breaking changes, new features, or improvements. Users should verify that the application functionality remains intact with the new SDK version.
https://claude.ai/code/session_01AxTjrk8DnF21ZiEsX2VKA5