Add /etc configuration file for deamon installation, fixes stale README - #243
Conversation
| # the user config file. Admin-only fields loaded from /etc/ are never | ||
| # written to ~/.config/ unless explicitly changed during a session. |
There was a problem hiding this comment.
This is going to make things very confusing user experience. A user will now be changing config in /etc/sendspin but won't see it applied, because at runtime something was changed.
| ``` | ||
|
|
||
| **Configuration:** Edit `/etc/default/sendspin` to change client name, audio device, or delay settings. | ||
| **Configuration:** Edit `/etc/sendspin/settings-daemon.json` to change client name, audio device, or other settings. This file is created by the installer and is readable by the daemon but only writable by root. Runtime state (last connected server, volume, etc.) is stored separately in `~/.config/sendspin/settings-daemon.json` — fields there take priority over `/etc/`. |
There was a problem hiding this comment.
Yeah, this is making things too complicated.
Let's fix the README instead and call it a day.
There was a problem hiding this comment.
I agree that this makes things more complex and I value simplicity too. For now I'll just change the README as you suggested.
That being said, the complexity has it's root in the runtime storing data in the same settings file the user uses for the deamon, which is a weird pattern imo. But if and when that needs fixing that's a separate issue.
There was a problem hiding this comment.
Ok done, this is now a simple README fix and can be merged.
Replace references to the old shell-based config with the correct ~/.config/sendspin/settings-daemon.json path.
3 participants
fixes #242
Implemented /etc/sendspin/settings-daemon.json configuration file, to make Sendspin deamon configuration easier for admins and fix the incorrect stale info in the README.