fix(sources): cap compressed and decompressed payload size to prevent OOM - #134
Merged
Merged
Conversation
…nt and connections
janmejay-s1
reviewed
Aug 13, 2026
janmejay-s1
left a comment
janmejay-s1
left a comment
Contributor
There was a problem hiding this comment.
If we have used any global variables anywhere else, let us delete those too, haven't completed the first pass yet, but adding comments I have gathered so far to unblock.
janmejay-s1
reviewed
Aug 13, 2026
janmejay-s1
reviewed
Aug 13, 2026
janmejay-s1
reviewed
Aug 13, 2026
janmejay-s1
left a comment
janmejay-s1
left a comment
Contributor
There was a problem hiding this comment.
Inject &CompressionLimits here: lib/codecs/src/actions/decoding/config.rs:44
janmejay-s1
reviewed
Aug 13, 2026
janmejay-s1
left a comment
janmejay-s1
left a comment
Contributor
There was a problem hiding this comment.
partial review, continuing
janmejay-s1
reviewed
Aug 13, 2026
janmejay-s1
left a comment
janmejay-s1
left a comment
Contributor
There was a problem hiding this comment.
partial, continuing to review
janmejay-s1
approved these changes
Aug 13, 2026
janmejay-s1
left a comment
janmejay-s1
left a comment
Contributor
There was a problem hiding this comment.
Accepted with comments, please address before merge.
Replaces the OnceLock globals with a CompressionLimits type carried in GlobalOptions, per review on #134. Does NOT compile: 31 errors remain across 15 files where each source still needs to take limits from its own context. Complete and compiling in isolation: - vector-common: CompressionLimits + OperationalLimits as configurable components; statics, setter, getters and free functions deleted. Derived values (zlib expansion, zstd window) are methods that compute, not getters. - vector-core: GlobalOptions.limits incl. merge precedence; Decompressor via From<(Compression, CompressionLimits)>; ZstdDecoder::new(reader, limits). - codecs: chunked_gelf carries limits; FramingConfig::build(limits); DecodingConfig::with_compression_limits() avoids touching 31 new() callers. - CappedDecoder::{gzip,zlib,zstd,zstd_http} take &CompressionLimits; the four *_with_limit variants deleted. - src/cli.rs: --max-decompressed-size-bytes, its parser and its tests removed. - http/encoding.rs: decode() and decode_with_limit() collapsed into one that takes limits; capped_body(limits). HttpSource prelude sources them from cx. - opentelemetry fully wired. Remaining: splunk_hec, datadog_agent (+metrics/logs/traces), otel http, prometheus remote_write, logstash, fluent, aws_kinesis_firehose, sources/vector, grpc decompression, sinks/util/rejection_report, components/validation. Pattern to follow: let compression_limits = cx.globals.limits.compression; at each source's build(), stored on the source struct where the decode happens, passed as &CompressionLimits. Note: CompressionLimits is a single usize and derives Copy, so the reviewer's concern about From<(Compression, &'a CompressionLimits)> causing a lifetime explosion does not arise - no lifetime parameter and no Arc needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sources that decompress untrusted input fed client-controlled payloads into
unbounded
read_to_endcalls, letting a small upload drive an arbitrarily largeallocation and OOM-kill the daemon. Port upstream's
CappedDecoder(vectordotdev/vector#25819, commit 3162ed1a2e) into
vector-commonand apply itat every affected call site.
The cap defaults to 100 MiB and is tunable with
--max-decompressed-size-bytes/VECTOR_MAX_DECOMPRESSED_SIZE_BYTES. Oversized payloads are rejected rather thanbuffered. For zstd the decoder window is clamped as well, since a crafted frame
allocates its window before emitting any output and so escapes an output-size
cap entirely; under HTTP the clamp follows RFC 9659's 8 MB ceiling.
Tickets fixed:
OBE-11554
OBE-11237
OBE-11233
OBE-10708 — same call site as OBE-11233
OBE-10706
OBE-10711
OBE-10710
OBE-11557
OBE-11559 - 61b436a logstash malformed frames #25664, #25825