examples: Collapse nested ifs in tag_stripper - #689
Open
jfietz wants to merge 1 commit into
Open
Conversation
`cargo clippy --all-targets` fails on the latest stable toolchain with two `clippy::collapsible_if` errors in this example. Now that let-chains are available on the current MSRV (1.89, edition 2024), the conditions can be collapsed into a single `if`. No behavioral change - a failure at any step still falls through to the "Unexpected input" branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the
cargo fmt/cargo clippy/cargo docstep inCONTRIBUTING.md before opening a PR, the command
cargo clippy --all-targetsfails on current stable (clippy 0.1.97) with two issues:CI does not currently catch this, as it runs
cargo clippy --all-featureswithout
--all-targets, so the examples are never linted.No behavioral change - a failure at any step still falls through to the
"Unexpected input" branch.