Refactor/phase1 code path consolidation - #195
Merged
Merged
Conversation
raghavm243512
force-pushed
the
refactor/phase1_code_path_consolidation
branch
from
July 27, 2026 21:37
94a9054 to
78feef1
Compare
…idation' into refactor/phase2_recording_consolidation # Conflicts: # src/eva/assistant/base_server.py
Removed some duplicate implementations of saving audio Removed buffers being tracked but unused Remove duplicate saving of audio Tested end to end locally, net change in behavior is none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combing code that is separate and could instead be reused.
This will enable backends to share tool calling implementation and logging
Also updated the backend / role classes to match the newly added fallback. They are still skeletons like #190
End to end testing done locally, everything is identical (though recording order changed slightly, so some tool calls on non S2S runs will be added to audit log a couple milliseconds earlier)