feat/pause video on click#562
Closed
ZemyCode wants to merge 3 commits into
Closed
Conversation
AnatoleAM
suggested changes
May 2, 2023
|
|
||
| const pauseOnClickEnabled = useConfig<boolean>("channel.video_player.pause_on_click"); | ||
|
|
||
| const videoPlayerClickHandler = document.querySelector('div[data-a-target="player-overlay-click-handler"]'); |
Contributor
There was a problem hiding this comment.
Please don't use DOM operations. We have built an array of React utilities capable of hooking Twitch's components, you can see those under common/ReactHooks.ts and common/Reflection.ts.
In order to hook to hook the relevant component, a predicate such as this might work (untested, only visually found this scrolling through the react tree)
(n) => n.props && n.props.mediaPlayerInstance && n.props.videoContainer
Closed
Contributor
|
Superseded by #727 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Reference: #484
This PR adds a "VideoPlayerModule" and with this module the feature to pause the video player on click is added.
Event listener is added on page load or when the setting is enabled, and the event listener is removed when setting is disabled.
Setting is false by default.
Added a sub category to "Channel" called "Video Player" for this setting. Would like feedback on if I should move to a different category or change the name at all. Possibly "General" instead of "Channel"?