add media-player module#608
Closed
chipsTM wants to merge 5 commits into
Closed
Conversation
AnatoleAM
suggested changes
May 16, 2023
AnatoleAM
suggested changes
May 18, 2023
Contributor
AnatoleAM
left a comment
AnatoleAM
left a comment
There was a problem hiding this comment.
Thanks for the cleanup so far 🙂
|
|
||
| definePropertyHook(props.instance.component, "props", { | ||
| value: (v: Twitch.MediaPlayerComponent["props"]) => { | ||
| if (v.mediaPlayerInstance) { |
Contributor
There was a problem hiding this comment.
Assign v.mediaPlayerInstance to a ref and use a watcher. You can see an example of this here:
https://github.com/SevenTV/Extension/blob/master/src/site/twitch.tv/modules/chat/ChatController.vue#L246
By doing this we are making vue handle diffing and avoid re-hooking the component many times. This also ensures that if we receive a different pointer, the hooks can be removed from the previous one.
Comment on lines
+116
to
+121
| const videoElement = mediaPlayer.core.mediaSinkManager.video; | ||
| if (!videoElement) return; | ||
|
|
||
| const overlayContainer = videoElement.nextElementSibling?.querySelector<HTMLElement>( | ||
| "div[data-a-target='player-overlay-click-handler']", | ||
| ); |
Contributor
There was a problem hiding this comment.
nit: can avoid optional chaining
Suggested change
| const videoElement = mediaPlayer.core.mediaSinkManager.video; | |
| if (!videoElement) return; | |
| const overlayContainer = videoElement.nextElementSibling?.querySelector<HTMLElement>( | |
| "div[data-a-target='player-overlay-click-handler']", | |
| ); | |
| const videoElement = mediaPlayer.core.mediaSinkManager.video; | |
| if (!videoElement || !videoElement.nextElementSibling) return; | |
| const overlayContainer = videoElement.nextElementSibling.querySelector<HTMLElement>( | |
| "div[data-a-target='player-overlay-click-handler']", | |
| ); |
Comment on lines
+36
to
+41
| const rootNode = inst.domNodes.root; | ||
| if (rootNode) { | ||
| const teleLoc = rootNode.querySelector<HTMLElement>("[data-a-target*='channel-viewers-count']") | ||
| ?.parentElement?.parentElement?.parentElement; | ||
| videoStatsTeleportLocation.value = teleLoc; | ||
| } |
Contributor
There was a problem hiding this comment.
nit: less depth
Suggested change
| const rootNode = inst.domNodes.root; | |
| if (rootNode) { | |
| const teleLoc = rootNode.querySelector<HTMLElement>("[data-a-target*='channel-viewers-count']") | |
| ?.parentElement?.parentElement?.parentElement; | |
| videoStatsTeleportLocation.value = teleLoc; | |
| } | |
| const rootNode = inst.domNodes.root; | |
| if (!rootNode) return; | |
| const teleLoc = rootNode.querySelector<HTMLElement>("[data-a-target*='channel-viewers-count']") | |
| ?.parentElement?.parentElement?.parentElement; | |
| videoStatsTeleportLocation.value = teleLoc; |
| <p>Video: {{ props.width }}x{{ props.height }}p{{ props.framerate }}</p> | ||
| <p>Bitrate: {{ props.bitrate }} kbps</p> | ||
| <p>Dropped Frames: {{ props.droppedFrames }}</p> | ||
| <br /> |
Contributor
There was a problem hiding this comment.
nit: use css instead of <br />
Closed
Contributor
|
The master branch has its own Player module, please refactor in a new pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add the foundational work of working with the media player by combining several requested features into one PR.
Player Settings Section
Stream info tooltip
Showcasing Twitch's auto speed up
Successful merge of this PR will close #485 and #562