Skip to content

fix(twitch): support lowercase cheers#981

Merged
TroyKomodo merged 4 commits into
SevenTV:feat/bug-fixesfrom
pimothyxd:fix/add-lowercase-cheer
Feb 17, 2024
Merged

fix(twitch): support lowercase cheers#981
TroyKomodo merged 4 commits into
SevenTV:feat/bug-fixesfrom
pimothyxd:fix/add-lowercase-cheer

Conversation

@pimothyxd
Copy link
Copy Markdown
Contributor

If a user sends a cheer in chat it is meant to be turned into an emote with it's text colored differently. It can be sent as it's lowercase and uppercase variant (e.g. "cheer1" & "Cheer1"). 7TV currently seems to only support the uppercase variant.

See the following example (msg lit. "cheer123456 Cheer123456"):

before

which should now look like this:

after

Should fix: #453

@pimothyxd pimothyxd changed the title fix: support lowercase cheers fix(twitch): support lowercase cheers Dec 22, 2023
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@TroyKomodo TroyKomodo changed the base branch from master to feat/bug-fixes February 17, 2024 01:12
@TroyKomodo TroyKomodo merged commit 8d97a71 into SevenTV:feat/bug-fixes Feb 17, 2024
@pimothyxd pimothyxd deleted the fix/add-lowercase-cheer branch March 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cheer case sensitivity issue

3 participants