-
Notifications
You must be signed in to change notification settings - Fork 1
Add Daisy Chain Board - PCB #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Daisy Chain Board - PCB #84
Conversation
|
Per 1/29: @knvprasad-dr and I have gone through and reviewed the PCB layout. Below are screenshots of the current layout along with a passed DRC report. DRC Report
Schematic
3D
|
…-Group/AMDS into daisy-chain-board-rev-a-pcb
knvprasad-dr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mohamed-dek1, PCB looks good to me.
- Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? No PCB files are larger than 300 kB
- Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
- Do all Markdown files follow the CONTRIBUTING article template? NA
- Do all links work in the material that the PR is adding? NA
- Is the PR configured to close the correct issue(s)? Yes
- Did the PR fully address the
Approachsection of the issue(s) it is closing? Yes
Prof. @elsevers, I have checked files by opening them in the lab system and they look fine, could you please review this PR.
elsevers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mohamed-dek1 and @knvprasad-dr. I am approving this based on seeing the files are named reasonably. I have not done a detailed review and so am counting on your careful review. One question I do have: what size stand-offs is this specified for? Is it the same as the AMDC or AMDS?
If yes: and if you are comfortable with this, I say go ahead and merge.









Closes #86
Notes
Anything reviewers should be aware of when reviewing? Other related issues? Known problems? Future work?
Self-Review
Approachsection of the issue(s) it is closing? YesReviewer Instructions
Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.
Appendix
This section should be the same for all PRs. Do not edit this section when creating a PR.
Review Checklists
Checklists maintained by the eLev lab for research repositories include:
Standard checklist
PCB
2D
3D Top
3D Bottom
@knvprasad-dr can you review this?