This repository was archived by the owner on May 9, 2023. It is now read-only.
Merged
Conversation
added 3 commits
January 11, 2019 13:16
Owner
|
Thank you for PR. |
Owner
|
Also there is a nice Feature Request: Maybe you can implement it also if you have some passion further :) |
ShahriyarR
pushed a commit
that referenced
this pull request
Feb 7, 2020
* Version bump * Bugfix issue345 (#346) * Config accepts both max_archive_[size/duration] OR archive_max_[size/duration], for backward compatibility * update comparison to use archive_max_[size/duration] * update variable names in test config generator (archive_max_[size/duration]) * Fixed #307 * update logging format to include module/line# * create process_runner / ProcessRunner class * use ProcessRunner for prepare statements. * use ProcessRunner for Backup statements; update add_tag() function to require fewer arguments. closes #307 * include process_runner module in setup.py * Update process_runner.py * fix add_tag() logic * Updating some portions (#352) * update pigz test so it will return exitcode 0 for ProcessRunner to function. update 2 incorrect calls to ProcessRunner(). (#357) * small updates to logging in autoxtrabackup.py (#359) * logging debug -> info for most modules (#360) * subprocess str -> args update; upgrade to subprocess logging; update subprocess calls with '--password=' string; log a subprocess summary on quit; (#362) * Removed redundant dependency package Co-authored-by: gitmstoute <mstoute@eyereturn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main component to this fix is generalops.py was checking for max_archive_size in BCK, but then trying to assign archive_max_size (instead of what it checked for: max_archive_size). So, the variables were never being set properly.
archive_max_[size/duration] seems like the preferred variable names so I cleaned that up a bit throughout the project.
closes 345