Feat/multi upload progress - #678
Merged
ShaneIsrael merged 3 commits intoJul 20, 2026
Merged
Conversation
Owner
|
I like it. Code looks fine at a glance. Going to put copilot on to review as well just as an added check since it is an update to the upload process. |
There was a problem hiding this comment.
Pull request overview
This PR implements a multi-file upload experience for videos, adding a client-side upload queue with per-file progress rows and a batch metadata dialog, while keeping the single-file UI path intact.
Changes:
- Updated global drag/drop to pass all dropped files to the upload card rather than only the first file.
- Reworked
UploadCardto enqueue multiple files, upload up to 3 concurrently, and render per-file + aggregate progress UI. - Extended the pre-upload dialog to apply shared metadata across the batch while allowing per-file editable titles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/client/src/components/utils/GlobalDragDropOverlay.js | Sends all dropped files to the registered upload handler (openFiles) instead of only the first file. |
| app/client/src/components/cards/UploadCard.js | Adds multi-upload queue, concurrency limiting, per-file/aggregate progress UI, and batch metadata/title handling. |
Comments suppressed due to low confidence (1)
app/client/src/components/cards/UploadCard.js:298
imageThumbnailUrlRefis never assigned anywhere in this component, but it is still being revoked here. This is dead code and can mislead future changes (and suggests a missing assignment that doesn't exist). Remove this block (and the unused ref if no longer needed).
if (imageThumbnailUrlRef.current) {
URL.revokeObjectURL(imageThumbnailUrlRef.current)
imageThumbnailUrlRef.current = null
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+541
to
+544
| const loadedQueueBytes = uploadQueue.reduce( | ||
| (sum, i) => sum + (i.status === 'done' || i.status === 'processing' ? i.file.size : i.progress * i.file.size), | ||
| 0, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #676
Details
Added bulk video uploading:
concurrently) instead of dropping the rest
Done / Failed) plus an aggregate header; single-file uploads keep
their existing look unchanged
batch, with a per-file editable title so each clip can still get its
own name
Demo
bulkuploaddemo.mp4