Add review window to PR workflow

[sri-rang]

Summary

• monitor PR review feedback for seven minutes alongside CI
• classify human and bot findings with actionable recommendations
• require explicit user permission before merging
• recheck feedback immediately before merge

Validation

• make lint — passed
• make test — passed (7/7 tests)
• make validate — passed
• dev-pr skill validator — passed

[qodo-code-review]

PR Summary by Qodo

Add 7-minute review window gate to dev-pr workflow

📝 Documentation ⚙️ Configuration changes 🕐 10-20 Minutes

AI Description

• Add a seven-minute PR review window running in parallel with CI monitoring.
• Classify human/bot review findings and require user decisions before proceeding.
• Require explicit merge permission and re-check feedback immediately before merging.

Diagram

graph TD
  U([User]) --> S["$dev-pr skill"] --> PR["GitHub PR"]
  PR --> CK["Required checks"] --> G["Merge gate (reviews+permission)"]
  PR --> RV["Review window (7m)"] --> G --> M["Rebase merge + cleanup"]

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Rely solely on GitHub branch protections (required reviews)

• ➕ Enforces review gates server-side rather than via a polling workflow
• ➕ Avoids arbitrary time windows and reduces polling complexity
• ➖ Does not capture non-blocking but substantive comments unless configured/reviewed
• ➖ May not align with repos that intentionally allow merges without required reviews

2. Make the review window duration configurable

• ➕ Adapts to different team norms and PR sizes (e.g., 2m vs 15m)
• ➕ Reduces the chance of under/over-waiting for review feedback
• ➖ Adds configuration surface area and potential user confusion
• ➖ Harder to standardize behavior across invocations

3. Event-driven review detection (webhooks/notifications) instead of polling

• ➕ More responsive and avoids repeated API polling
• ➕ Can stop immediately on new feedback events
• ➖ More infrastructure and setup complexity than a skill-level polling loop
• ➖ Harder to implement portably across environments

Recommendation: The PR’s approach (fixed seven-minute parallel review window + explicit user permission + final re-check) is a pragmatic safety gate for a CLI/skill workflow without extra infrastructure. If this becomes a team-wide standard, consider making the window configurable or leaning more on GitHub branch protections to reduce reliance on polling semantics.

Files changed (2) +38 / -9

Documentation (1) +36 / -7

SKILL.mdAdd 7-minute review window and merge-permission gate +36/-7

Add 7-minute review window and merge-permission gate

• Updates the dev-pr skill spec to run a seven-minute code-review polling window in parallel with required check monitoring. Defines what counts as substantive feedback, how to present findings for user decision, and requires explicit permission plus a final pre-merge review re-check.

.codex/skills/dev-pr/SKILL.md

Other (1) +2 / -2

openai.yamlAlign agent prompt with review + permission workflow +2/-2

Align agent prompt with review + permission workflow

• Adjusts the agent display text and default prompt to reflect monitoring reviews alongside checks and requiring user permission before merging.

.codex/skills/dev-pr/agents/openai.yaml

[qodo-code-review]

No code issues found._{ⓘ  0 issues published inline · 0 in summary — for nitpicking, see all findings}

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

[qodo-code-review]

PR approved by Qodo

All merge criteria satisfied — approved by default policy

[qodo-code-review]

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.