misc fixes#76
Merged
Merged
Conversation
SharpBit
reviewed
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Description
Using
await player.get_club()would result in a TypeError when the user isn't part of any club, as you can't await None. This PR fixes that by returning an awaitable function - if the client is asyncronously used - that resolves to None.The
brawlstats.utils.get_datetimefunction seemed to use the wrong string format - probably because it's Star List API legacy code. There would also be a SyntaxError regarding the type annotation, which I've also fixed.Type of PR
Checklist
If necessary, add to the documentation files