WIP: upgrade to scala 2.13.0 #334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it'd be better to resolve this cyclic dependency...
mpollmeier
force-pushed
the
michael/scala-2.13.0
branch
from
322dd15 to
9fbe028
Compare
mpollmeier
force-pushed
the
michael/scala-2.13.0
branch
from
9fbe028 to
f696f68
Compare
fabsx00
approved these changes
Sep 2, 2019
|
I'll fix the new deprecation warnings before merging (not today). if possible please approve so i can move quickly tmr |
hubertp
reviewed
Sep 2, 2019
codepropertygraph/src/main/scala/io/shiftleft/codepropertygraph/cpgloading/ProtoToCpg.scala
Outdated
Show resolved
Hide resolved
codepropertygraph/build.sbt
Outdated
| println(s"successfully called $cmd") | ||
| else | ||
| if (result == 0) { | ||
| val outputRootBF = better.files.File(outputRoot.toPath) |
There was a problem hiding this comment.
outputRootBF that looks like a rather cryptic variable name and it took me a while until I figured out that BF doesn't stand for "best friends" 😢
There was a problem hiding this comment.
yeah, agree, changed that now
|
closing, replaced by multiple smaller prs |
Merged
mpollmeier
added a commit
that referenced
this pull request
Dec 2, 2019
* upgrade to scala 2.13.1 mostly reapplied #334 * use built-in ARM * upgrade sbt * compile works * fix compile deprecation warnings * bring converters back in * use my custom-published collections-contrib * fix deprecation warning * Disable fatal warnings on cpgserver. * temporarily disable fatal-warnings * inline reading overlay entries for simpler ARM handling * scalafmt * reenable xfatal warnings for other subprojects * fix tests * released fuzzyc * downgrade to 2.13.0 to fix cpg-server issue with ZipArchive underlying issue: scala/bug#11754 which is fixed in scala/scala#8447 i.e. we can upgrade to 2.13.2 once that's released shows as stackoverflow error recursing indefinitely: `scala.reflect.io.ZipArchive.ensureDir(ZipArchive.scala:126)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: do not merge for now, because the corresponding codescience PR isn't merge-ready. Many of our dependencies only exist as RCs and milestones, we want to wait for proper releases.