Correctly seed root direntry for ZipArchives #8447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MiMa objects to my package private constant value definition for slash. Whitelisting is so tiresome, I may just revert that. Or maybe try the exclusion. Would be nice to have a |
som-snytt
force-pushed
the
issue/11754
branch
3 times, most recently
from
0dc000f to
54b79b5
Compare
lrytz
reviewed
Oct 10, 2019
| ), fs) | ||
| val assignedInConstr = getMethod(k, "<init>").instructions.filter(_.opcode == Opcodes.PUTFIELD) map { | ||
| case f: Field => f.name | ||
| case _ => ??? // @unchecked |
There was a problem hiding this comment.
yeah, @unchecked would be cleaner
som-snytt
force-pushed
the
issue/11754
branch
from
54b79b5 to
2863bf4
Compare
|
Rebase, squash, resolve hot lines of mima exclusions. |
som-snytt
commented
Oct 21, 2019
Local test and code cleanup and MiMa exclusion for RootEntry. Improve lookupfactory test, spell Closeable. Arguably simplify code in LookupFactory.
som-snytt
force-pushed
the
issue/11754
branch
from
2863bf4 to
db2b70b
Compare
|
@som-snytt this PR seems to be causing test failures on Windows: https://scala-ci.typesafe.com/view/scala-2.13.x/job/scala-2.13.x-integrate-windows/1157/ and all subsequent runs as well |
|
@SethTisue thanks for the heads up. I don't know why I didn't run the test suite on a windows box a long time ago. I'll take a look. |
|
Possible fix at #8539 |
mpollmeier
added a commit
to joernio/joern
that referenced
this pull request
Nov 27, 2019
script tests failed due to scala/bug#11754 Which is fixed in scala/scala#8447, i.e. we can upgrade to 2.13.2 once that's released
mpollmeier
added a commit
to ShiftLeftSecurity/codepropertygraph
that referenced
this pull request
Dec 2, 2019
underlying issue: scala/bug#11754 which is fixed in scala/scala#8447 i.e. we can upgrade to 2.13.2 once that's released shows as stackoverflow error recursing indefinitely: `scala.reflect.io.ZipArchive.ensureDir(ZipArchive.scala:126)`
mpollmeier
added a commit
to ShiftLeftSecurity/codepropertygraph
that referenced
this pull request
Dec 2, 2019
* upgrade to scala 2.13.1 mostly reapplied #334 * use built-in ARM * upgrade sbt * compile works * fix compile deprecation warnings * bring converters back in * use my custom-published collections-contrib * fix deprecation warning * Disable fatal warnings on cpgserver. * temporarily disable fatal-warnings * inline reading overlay entries for simpler ARM handling * scalafmt * reenable xfatal warnings for other subprojects * fix tests * released fuzzyc * downgrade to 2.13.0 to fix cpg-server issue with ZipArchive underlying issue: scala/bug#11754 which is fixed in scala/scala#8447 i.e. we can upgrade to 2.13.2 once that's released shows as stackoverflow error recursing indefinitely: `scala.reflect.io.ZipArchive.ensureDir(ZipArchive.scala:126)`
mpollmeier
added a commit
to joernio/joern
that referenced
this pull request
Dec 3, 2019
* upgrade to scala 2.13.1 * back to 2.13.0 due to a scala-reflect regression script tests failed due to scala/bug#11754 Which is fixed in scala/scala#8447, i.e. we can upgrade to 2.13.2 once that's released * undo local temp fix * apply tab completion workaround ammonite tab completion is partly broken for scala > 2.12.8 applying workaround for package wildcard imports from com-lihaoyi/Ammonite#1009 * latest versions * released versions
max-leuthaeuser
pushed a commit
to joernio/joern
that referenced
this pull request
Jul 29, 2022
* upgrade to scala 2.13.1 * back to 2.13.0 due to a scala-reflect regression script tests failed due to scala/bug#11754 Which is fixed in scala/scala#8447, i.e. we can upgrade to 2.13.2 once that's released * undo local temp fix * apply tab completion workaround ammonite tab completion is partly broken for scala > 2.12.8 applying workaround for package wildcard imports from com-lihaoyi/Ammonite#1009 * latest versions * released versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As diagnosed.
Fixes scala/bug#11754