upgrade to scala 2.13.1 #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by #506 |
GlassAndOneHalf
approved these changes
Nov 29, 2019
mostly reapplied #334
mpollmeier
force-pushed
the
michael/scala-2.13.1
branch
from
439ea39 to
97ddd6b
Compare
hubertp
approved these changes
Dec 2, 2019
| .as[CreateCpgRequest] | ||
| .flatMap(createCpg) | ||
|
|
||
| // TODO discuss with jacob: according to scalac this is unreachable... commenting for now since it probably never worked anyway |
There was a problem hiding this comment.
is that the scalac bug mentioned in build.sbt?
There was a problem hiding this comment.
if you mean this quote from cpgserver/build.sbt: yes
// Re-enable fatal warnings once this Scala 2.13 issue is fixed: https://github.com/scala/bug/issues/11457
scalacOptions -= "-Xfatal-warnings"
underlying issue: scala/bug#11754 which is fixed in scala/scala#8447 i.e. we can upgrade to 2.13.2 once that's released shows as stackoverflow error recursing indefinitely: `scala.reflect.io.ZipArchive.ensureDir(ZipArchive.scala:126)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly reapplied #334