DEV-875 Generalise the non-wear derived-sensor bit to the LSM6DS family (LSM6DSX)#278
Open
marknolan wants to merge 2 commits into
Open
DEV-875 Generalise the non-wear derived-sensor bit to the LSM6DS family (LSM6DSX)#278marknolan wants to merge 2 commits into
marknolan wants to merge 2 commits into
Conversation
…6DS family Non-wear detection is being extended to the second-generation LSM6DSV accel (SR68-9/10, SR61-5/6). The LSM6DS3 and LSM6DSV never coexist on one board, and the Verisense derived-sensors mask is a purely in-process enable key (never written to config bytes, DB, or cloud - unlike the frozen Shimmer3 namespace), so the existing bit 1 is renamed NON_WEAR_DETECTION_LSM6DSX and shared by both IMU generations rather than consuming a new bit. The old constant remains as a deprecated alias for source compatibility with consumers of the published jar. The algorithm-side change (merged LSM6DSX AlgorithmDetails with SENSOR_CHECK_METHOD.ANY) lives in the ASM_PC repo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Generalises the Verisense derived-sensors bitmask for non-wear detection so the same enable bit can be used across the LSM6DS IMU family (gen-1 LSM6DS3 and gen-2 LSM6DSV), while preserving source compatibility via a deprecated alias.
Changes:
- Rename
DerivedSensorsBitMask.NON_WEAR_DETECTION_LSM6DS3toNON_WEAR_DETECTION_LSM6DSX(same bit:1 << 1). - Add JavaDoc clarifying the shared-bit rationale and introduce a
@Deprecatedalias for the old constant name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #277 — merge that first, then retarget/merge this. Jira: DEV-875.
Renames
DerivedSensorsBitMask.NON_WEAR_DETECTION_LSM6DS3toNON_WEAR_DETECTION_LSM6DSX(same bit,1<<1) so a single non-wear algorithm variant can cover both the gen-1 LSM6DS3 and the gen-2 LSM6DSV:Shimmer3namespace (infomem/SD headers).@Deprecatedalias keeps source compatibility for consumers of the published jar.The algorithm-side change (merged
ALGO_NON_WEAR_DETECTION_LSM6DSXwithSENSOR_CHECK_METHOD.ANY) is in the companion ASM_PC PR on branchDEV-875_lsm6dsv_nonwear.🤖 Generated with Claude Code