test: assert all placement rotations preserve handedness

[olantwin]

Motivation

Follow-up to #70. That PR fixed a left-handed placement frame in SBTStructureBuilder (columns (b, n, d) with b = d × n, giving det < 0), which GeoModel2G4 forwarded to CLHEP::HepRotation as an improper rotation — 180 ZMpvImproperRotation warnings per Geant4 job. Nothing in CI prevents that class of bug from returning, and the frame construction is duplicated across two sites in SBTStructureBuilder.cpp, so any future builder could reintroduce it.

Change

Add ConsistencyTest.AllRotationsRightHanded, which builds the full geometry via SHiPGeometryBuilder and recursively walks the entire world tree, asserting that the linear part of every getXToChildVol transform has positive determinant. A reflection anywhere in the tree fails the test, naming the offending volume path. This covers all subsystems, not just the SBT structure, and pins the 180 → 0 property permanently.

Verification

• On the code prior to fix: make SBT beam placement frames right-handed #70, the test fails with exactly 180 reflection assertions (e.g. /SHiP/decay_volume/sbt/structure_SF9_Bot_C1_BF at determinant −1) — matching the count fix: make SBT beam placement frames right-handed #70 removed.
• On current main (with the fix), the full suite passes 40/40.

The walk visits all ~930k nodes and takes ~190 s, dominated by getXToChildVol materializing GeoSerialTransformer replicas. Global scope is intentional, to guard every current and future builder.

[coderabbitai]

Warning

Review limit reached

@olantwin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c077174f-23d2-4139-b524-1032cea339cc

📥 Commits

Reviewing files that changed from the base of the PR and between c6d866b and c83b7df.

📒 Files selected for processing (1)

• tests/test_consistency.cpp

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/rotations-right-handed

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}