Skip to content

fix: add mp-units to package host dependencies#19

Merged
olantwin merged 1 commit into
mainfrom
fix/host-mp-units
Jul 23, 2026
Merged

fix: add mp-units to package host dependencies#19
olantwin merged 1 commit into
mainfrom
fix/host-mp-units

Conversation

@olantwin

Copy link
Copy Markdown
Contributor

Problem

Building shipdatamodel as a pixi source dependency (e.g. in aegir's dev environment) fails at CMake configure:

CMake Error at CMakeLists.txt:9 (find_package):
  Could not find a package configuration file provided by "mp-units"
  (requested version 2.5)

CMakeLists.txt does find_package(mp-units 2.5 CONFIG REQUIRED) for the SHiP::SHiPUnits target, so mp-units is a build (host) dependency. But it was only listed in the workspace [dependencies] (this repo's own dev env), not in [package.host-dependencies] — which is what pixi-build-cmake uses to assemble the host environment. So the source build's host prefix has no mp-units.

The release recipe (ship-conda-recipes/recipes/shipdatamodel) already lists mp-units in its host:; this just mirrors it, per the manifest's own "keep the host dependencies in lockstep with [the release recipe]" note.

Fix

[package.host-dependencies]
root_base = { version = "*", build = "cxx23_*" }
root_cxx_standard = "==23"
mp-units = ">=2.5"   # <-- add

Verification

Verified end-to-end locally (pixi 0.68.1, current main, refreshed ship channel): with this change, aegir's dev-source build resolves and completes fully — all three source packages build, pixi install -e dev, aegir's own build/install, and the smoke task (pythia8 benchmark + phlex gun_noop) all pass.

Context

Third and final fix in the chain exposed by aegir's dev-source-build tripwire (ShipSoft/ship-conda-recipes#106); follows data-model#18 (cxx20 root_base) and ship-conda-recipes#133 (geomodel-core channel refresh).

CMakeLists.txt does `find_package(mp-units 2.5 CONFIG REQUIRED)` for the
SHiP::SHiPUnits target, so mp-units is needed in the build (host)
environment. It was only listed in the workspace `[dependencies]` (this
repo's own dev env), not in `[package.host-dependencies]`, so building
shipdatamodel as a pixi source dependency fails at CMake configure:

    Could not find a package configuration file provided by "mp-units"
    (requested version 2.5)

The release recipe (ship-conda-recipes/recipes/shipdatamodel) already
lists mp-units in its host:; mirror it here.
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@olantwin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 753f1a37-18db-491a-81ce-1e69aa61de72

📥 Commits

Reviewing files that changed from the base of the PR and between 2563809 and 0e5be44.

📒 Files selected for processing (1)
  • pixi.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/host-mp-units

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olantwin
olantwin merged commit f2317af into main Jul 23, 2026
4 checks passed
@olantwin
olantwin deleted the fix/host-mp-units branch July 23, 2026 07:50
@olantwin
olantwin restored the fix/host-mp-units branch July 23, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant