chore: bump ci-triage to v1.3 - #15
Merged
Merged
Conversation
This is the change that actually silences the Node 20 deprecation warning. It came from actions/upload-artifact inside ci-triage's upload-report composite action, so bumping this repo's own actions was necessary but not sufficient. v1.3 also carries the fork-triggered-run guard upstream, which makes the guard in ci-failure-triage.yml redundant for the reusable workflow's own jobs. It is kept regardless: caller-owned jobs like notify-slack use `always()` and run even when triage is skipped, and upstream cannot guard those. Release tags here are immutable — ci-triage's `release-tags` ruleset blocks deletion, update, and non-fast-forward on `refs/tags/v*`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Both fixture workflows listed their own workflow file in their pull_request paths, so editing either one reddened the PR doing the editing — which is what happened to this PR while it was only bumping a version string. Spec Drift Fixture keeps its pull_request trigger, scoped to the TEST file alone. That preserves the behaviour the earlier split existed for: the auto-fix PR edits the test, so it still triggers this workflow and still goes green. App Regression Fixture loses pull_request entirely. It is permanently red — the fix belongs in a third-party page we do not control — so it has no green end state and could only ever redden a PR. Exercise it with workflow_dispatch. Verified by path-matching every workflow filter: editing either fixture workflow now triggers nothing, while a change to 01-spec-drift.test.yaml still triggers Spec Drift Fixture. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps all five references from
@v1.2to@v1.3.This is the change that actually silences the Node 20 deprecation warning — it came from
actions/upload-artifactinside ci-triage'supload-reportcomposite action, so PR #11's bump of this repo's own actions was necessary but not sufficient.v1.3 also carries the fork-triggered-run guard upstream. That makes the guard in
ci-failure-triage.ymlredundant for the reusable workflow's own jobs — it is kept regardless, because caller-owned jobs likenotify-slackusealways()and run even when triage is skipped, which upstream cannot guard.Release tags here are immutable: ci-triage's
release-tagsruleset blocks deletion, update, and non-fast-forward onrefs/tags/v*.🤖 Generated with Claude Code