Skip to content
This repository was archived by the owner on Jul 31, 2026. It is now read-only.

ci: replace the dead live smoke test with the unit tests, fix CODEOWNERS - #39

Merged
will-shiplight merged 1 commit into
masterfrom
ci/fix-dead-smoke-test-and-codeowners
Jul 31, 2026
Merged

ci: replace the dead live smoke test with the unit tests, fix CODEOWNERS#39
will-shiplight merged 1 commit into
masterfrom
ci/fix-dead-smoke-test-and-codeowners

Conversation

@will-shiplight

Copy link
Copy Markdown
Contributor

Follow-up to #38. These two commits were meant to ride along with it, but #38 merged first.

The CI job cannot be repointed, so it is removed

GitHub Actions Test ran the action for real against secrets.LOGGIA_*. The API now answers:

[shiplight] starting single test run ...
##[error]Failed to start batch test run: Batch test run not found

The suite and environment those secrets name belong to Shiplight Cloud v1 and no longer exist. There is nowhere else to point it: this action only speaks to the v1 API, and the current platform's CI path does not use this action at all, so no v2 target exists to swap in.

Left alone, this job fails on every pull request to this repo forever, which trains everyone to ignore a red X.

What replaces it

The unit tests that were already sitting commented out in the same workflow:

-      # - name: Test
-      #   id: npm-ci-test
-      #   run: npm run ci-test
+      - name: Test
+        id: npm-ci-test
+        run: npm run ci-test

They pass and need no live backend:

PASS __tests__/main.test.ts
  main.ts
    ✓ Sets a failed status for missing API token
    ✓ Parses test-context lines and trims surrounding whitespace
    ✓ Rejects test-context lines with an empty key

Tests: 3 passed, 3 total

Three tests is thin, and statement coverage across src/ is 13.5%. But green and testing a little beats red and testing nothing, and it gives anyone adding coverage later a job to add it to.

Workflow permissions

Dropped from permissions: write-all to contents: read. With the smoke test gone, nothing in this workflow comments on a pull request, so nothing needs write.

CODEOWNERS

-* @actions/actions-oss-maintainers
+* @feng-shiplight

The old value is the actions/typescript-action template default. That team does not exist in this org, so every PR here landed with no reviewer requested, including #38.

Branch protection has require_code_owner_reviews: false, so this changes who gets auto-requested, not who is allowed to approve.

Still template leftovers, not touched here

package.json identifies as "name": "typescript-action" with homepage, repository, and bugs all pointing at actions/typescript-action. Harmless (the package is private: true and never published) but wrong if anyone reads it.

🤖 Generated with Claude Code

The GitHub Actions Test job ran the action for real against
secrets.LOGGIA_*, and the API now answers "Batch test run not found":
the suite and environment those secrets point at belong to Shiplight
Cloud v1 and no longer exist. There is nowhere to repoint it. This
action only speaks to the v1 API, and the current platform's CI path
does not involve this action at all, so no v2 equivalent exists.

Removed the job and enabled the unit tests that were sitting commented
out in the same workflow. They pass (3 tests, covering token validation
and test-context parsing) and they need no live backend, so CI is green
and testing something real rather than red and testing nothing.

Also dropped the workflow's permissions from write-all to contents:
read, which is all the remaining job needs now that nothing comments
on pull requests.

CODEOWNERS still carried the actions/typescript-action template default,
@actions/actions-oss-maintainers, a team that does not exist in this
org, so review requests silently went nowhere. Now @feng-shiplight.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@will-shiplight
will-shiplight merged commit ea680cb into master Jul 31, 2026
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant