This repository was archived by the owner on Jul 31, 2026. It is now read-only.
ci: replace the dead live smoke test with the unit tests, fix CODEOWNERS - #39
Merged
Merged
Conversation
The GitHub Actions Test job ran the action for real against secrets.LOGGIA_*, and the API now answers "Batch test run not found": the suite and environment those secrets point at belong to Shiplight Cloud v1 and no longer exist. There is nowhere to repoint it. This action only speaks to the v1 API, and the current platform's CI path does not involve this action at all, so no v2 equivalent exists. Removed the job and enabled the unit tests that were sitting commented out in the same workflow. They pass (3 tests, covering token validation and test-context parsing) and they need no live backend, so CI is green and testing something real rather than red and testing nothing. Also dropped the workflow's permissions from write-all to contents: read, which is all the remaining job needs now that nothing comments on pull requests. CODEOWNERS still carried the actions/typescript-action template default, @actions/actions-oss-maintainers, a team that does not exist in this org, so review requests silently went nowhere. Now @feng-shiplight. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38. These two commits were meant to ride along with it, but #38 merged first.
The CI job cannot be repointed, so it is removed
GitHub Actions Testran the action for real againstsecrets.LOGGIA_*. The API now answers:The suite and environment those secrets name belong to Shiplight Cloud v1 and no longer exist. There is nowhere else to point it: this action only speaks to the v1 API, and the current platform's CI path does not use this action at all, so no v2 target exists to swap in.
Left alone, this job fails on every pull request to this repo forever, which trains everyone to ignore a red X.
What replaces it
The unit tests that were already sitting commented out in the same workflow:
They pass and need no live backend:
Three tests is thin, and statement coverage across
src/is 13.5%. But green and testing a little beats red and testing nothing, and it gives anyone adding coverage later a job to add it to.Workflow permissions
Dropped from
permissions: write-alltocontents: read. With the smoke test gone, nothing in this workflow comments on a pull request, so nothing needs write.CODEOWNERS
The old value is the
actions/typescript-actiontemplate default. That team does not exist in this org, so every PR here landed with no reviewer requested, including #38.Branch protection has
require_code_owner_reviews: false, so this changes who gets auto-requested, not who is allowed to approve.Still template leftovers, not touched here
package.jsonidentifies as"name": "typescript-action"withhomepage,repository, andbugsall pointing atactions/typescript-action. Harmless (the package isprivate: trueand never published) but wrong if anyone reads it.🤖 Generated with Claude Code