Autoredirect remote profiles #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
autoredirect_after_remote_profile
branch
from
d741463 to
30ae916
Compare
Instead of logging profile viewing URLs, we can just redirect to them when the developer wants to see them. Saves copy-pasting the path.
gmcgibbon
force-pushed
the
autoredirect_after_remote_profile
branch
from
30ae916 to
84e9d86
Compare
bmansoob
reviewed
Dec 11, 2023
Contributor
bmansoob
left a comment
bmansoob
left a comment
There was a problem hiding this comment.
I am with you on making autoredirect the default behaviour.
Member
Author
|
I added a commit to make the behaviour default instead of opting into it with autoredirect. If we agree, I'll squash it and merge. |
bmansoob
reviewed
Dec 12, 2023
| end | ||
|
|
||
| def view | ||
| def view(response: nil, autoredirect: nil, async: false) |
Contributor
There was a problem hiding this comment.
I am not sure if we need autoredirect: nil, async: false here?
Member
Author
There was a problem hiding this comment.
Because we're passing in the parameters from the view action (from the middleware), we can expect these to be provided. If we don't mention them, Ruby will raise an ArgumentError and our public API will be broken if we don't provide defaults.
bmansoob
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support autoredirection on remote profile views. Previously, the remote speedscope viewer would log a line like
Profile available at /app_profiler/<profile-id>if a profile was initiated (eg.my.host/some/url?profile=wall). When autoredirection is enabled via the query param, header, or configuration (eg.my.host/some/url?profile=wall&autoredirect=1), a redirect is added to just redirect to/app_profiler/<profile-id>instead of having to copy-paste the log into the browser.Should we just make this the new default behaviour? It is much better DX.