Centralize sample storefront configuration#175
Open
kyle-schellen wants to merge 1 commit into
Open
Conversation
This was referenced May 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 20, 2026
c4e0c6b to
ad39f4f
Compare
d2be551 to
e86923e
Compare
ad39f4f to
1bf5d08
Compare
e86923e to
06f9f45
Compare
1bf5d08 to
8575e24
Compare
06f9f45 to
0e9dc0f
Compare
0e9dc0f to
8ebd042
Compare
8575e24 to
83df290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Depends on #69.
Stack position
This PR is the shared storefront configuration layer. It builds on the root
dev.ymlcommand foundation by introducing one repo-root sample configuration source and syncing it into the platform-specific files that Android, Swift, and React Native already consume.The next PR wires this into repo setup/bootstrap commands. This PR intentionally keeps the entry point as the direct script,
scripts/setup_storefront_env, so the configuration flow is reviewable on its own.What changes
.env.examplewith shared sample storefront, Customer Account API, Apple Pay, and buyer identity fields.scripts/setup_storefront_envto create, normalize, sync, and check generated platform config files from the root.env.scripts/test_setup_storefront_envcoverage for required-only setup, optional value sync, stale generated config detection, migration from older config shapes, and sanitized setup output.PREFILL_EMAIL/PREFILL_PHONEvalues.API_VERSION, keepSTOREFRONT_VERSIONas a fallback, and log whether config values are present instead of printing local values.Review notes
The platform-local
.env.example/Storefront.xcconfig.examplefiles remain as local examples, but they now point contributors toward the root.env.exampleplusscripts/setup_storefront_envas the preferred shared setup path.Android schema download still reads the Android sample
.envand prints the endpoint details during that human-invoked command. The shared setup script itself only prints file paths/status and avoids echoing configured values.How to test
bash -n scripts/setup_storefront_env scripts/test_setup_storefront_envscripts/test_setup_storefront_envscripts/setup_storefront_env --checkscripts/setup_storefront_envand confirm these generated files are updated consistently:platforms/android/samples/MobileBuyIntegration/.envplatforms/react-native/sample/.envplatforms/swift/Samples/MobileBuyIntegration/Storefront.xcconfigplatforms/swift/Samples/ShopifyAcceleratedCheckoutsApp/Storefront.xcconfigBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
platforms/swift/ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.