Polish platform check tooling#177
Closed
kyle-schellen wants to merge 1 commit into
Closed
Conversation
This was referenced May 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
React Native — Coverage Report
|
kyle-schellen
force-pushed
the
ks-dev-workspace-setup
branch
from
ca5570f to
aef7cdc
Compare
kyle-schellen
force-pushed
the
ks-platform-check-tooling-polish
branch
from
cf2c28f to
3db57cb
Compare
kyle-schellen
force-pushed
the
ks-dev-workspace-setup
branch
from
aef7cdc to
ddc5f30
Compare
kyle-schellen
force-pushed
the
ks-platform-check-tooling-polish
branch
from
3db57cb to
24ab535
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #176.
Closes issue #908.
Stack position
This is the top PR in the dev-command stack. It contains small check-tooling and lint polish found while exercising the command matrix added downstack.
What changes
.gradleandbuilddirectories, so generated KSP/cache files do not faildev check.swiftlint/swiftformatfrom eitherPATHor the Swift platform Mint setup.Gemfileexplicitly from the repo root.Review notes
This PR is intentionally separated from the command/setup PRs because it is not part of the command architecture. These are follow-up fixes that make the new command matrix behave consistently against generated artifacts and shared Swift tooling.
No runtime behavior is intended to change.
How to test
dev checkdev android check license-headersdev react-native lint swiftdev react-native formatdev swift lintBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
platforms/swift/ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.