feat: incoming mesage origin validation for web#474
Draft
michaeljsXu wants to merge 1 commit into
Draft
Conversation
Contributor
Author
This was referenced Jul 15, 2026
| function isValidOriginPattern(pattern: string): boolean { | ||
| if (pattern === "*") return true; | ||
| if (pattern.includes("*")) return WILDCARD_ORIGIN_PATTERN.test(pattern); | ||
| return URL.canParse(pattern); |
Contributor
There was a problem hiding this comment.
I think this could break exact allowlist entries on Safari 16.4–16.6. URL.canParse starts in Safari 17, while this package supports Safari 16.4+. Could we validate with new URL(...) in a try/catch and add a test with URL.canParse unavailable?
| if (scheme === undefined || suffix === undefined) return false; | ||
|
|
||
| if (`${scheme.toLowerCase()}:` !== origin.protocol) return false; | ||
| if ((port ?? "") !== origin.port) return false; |
Contributor
There was a problem hiding this comment.
Could we normalize the configured wildcard port before comparing it? Browsers remove the default :443, so https://*.example.com:443 can reject a valid message from that origin. A regression test for explicit default ports would be helpful too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.