Flatten webview hierarchy#497
Open
kiftio wants to merge 1 commit into
Open
Conversation
kiftio
force-pushed
the
07-17-flatten_webview_hierarchy
branch
from
July 17, 2026 16:07
22c99c6 to
a6efc4e
Compare
kiftio
force-pushed
the
07-17-flatten_webview_hierarchy
branch
from
July 17, 2026 16:19
a6efc4e to
8a0592c
Compare
kiftio
marked this pull request as ready for review
July 17, 2026 16:20
Package Size
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
We still have a
BaseWebView.. This made sense withCheckoutWebViewandFallbackWebViewfor graceful degradation. Now we don't haveFallbackWebViewwe should flatten that down---
BaseWebViewhas been removed as an abstract base class. All of its functionality — WebView configuration, touch gesture handling, user agent suffix generation, back-press handling, navigation error handling, andremoveFromParent— has been consolidated directly intoCheckoutWebView.The
ECP_LOG_TAGandSCROLL_UP_DIRECTIONconstants previously nested insideBaseWebVieware now top-level package-level declarations, and references toBaseWebView.ECP_LOG_TAGacrossCheckoutProtocol,EmbeddedCheckoutProtocolBridge, andWebMessageTransporthave been updated accordingly.CheckoutBottomSheetScrollHandoffand test helpers that previously referencedBaseWebViewnow referenceCheckoutWebViewdirectly. Test subclasses (ScrollableBaseWebView,GestureTestWebView) have been updated to extendCheckoutWebViewinstead, removing the need to overridegetListener().How to test
CheckoutWebViewTest,CheckoutBottomSheetTest) and verify all tests pass.CheckoutKitAndroidDemosample app and complete a checkout flow end-to-end, verifying that progress indication, gesture handling (scroll handoff with the bottom sheet), back navigation, and error handling all behave correctly.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.