Add lifecycle dispatcher tests - #529
Merged
Merged
Conversation
Contributor
Author
This was referenced Jul 29, 2026
Merged
kiftio
marked this pull request as ready for review
July 29, 2026 08:58
Package Size
Web file breakdown
React Native file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
Warning Expected 2 runs, received 0 — 2 did not report. Missing runs count as failures until every run reports. |
This was referenced Jul 29, 2026
kieran-osgood-shopify
approved these changes
Jul 29, 2026
kiftio
changed the base branch from
07-29-include_protocol_in_root_development_commands
to
graphite-base/529
July 29, 2026 10:07
kiftio
force-pushed
the
graphite-base/529
branch
from
July 29, 2026 10:17
b351750 to
ddc9a0e
Compare
kiftio
force-pushed
the
07-29-add_lifecycle_dispatcher_tests
branch
from
July 29, 2026 10:17
3179972 to
227fe23
Compare
kiftio
changed the base branch from
graphite-base/529
to
07-29-include_protocol_in_root_development_commands
July 29, 2026 10:17
Contributor
Author
kiftio
changed the base branch from
07-29-include_protocol_in_root_development_commands
to
graphite-base/529
July 29, 2026 10:37
Assisted-By: devx/4075c309-3611-4ac8-9ea7-26a8974e7963
kiftio
force-pushed
the
07-29-add_lifecycle_dispatcher_tests
branch
from
July 29, 2026 10:38
227fe23 to
8185daf
Compare
This was referenced Jul 29, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Adds tests to verify correct lifecycle and subscription management behavior across the React Native and Web platforms:
onDispatchsubscription is released before a subsequentpresentcall, and that the subscription is cleaned up after a terminalcloseevent is received. Also adds a new test suite fordispatch-eventsverifying that SDK lifecycle event types are correctly recognized, that native event parity is verified only once regardless of subsequent calls, and that mismatches between native and JS event types are reported with clear error messages.Loggerutility, covering log level coercion, threshold-based message filtering, and lazy threshold evaluation.How to test
Run the test suites for the affected platforms:
yarn testwithin theplatforms/react-nativemoduleyarn testwithin theplatforms/webmoduleVerify all new and existing tests pass without errors.
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.