[Android] Setup sample lint and formatting - #585
Open
kiftio wants to merge 1 commit into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
kiftio
force-pushed
the
08-05-setup_sample_lint_and_formatting
branch
from
August 5, 2026 10:46
03d0a9b to
6b9b36a
Compare
11 tasks
kiftio
commented
Aug 5, 2026
| android:layout_height="wrap_content" | ||
| android:elevation="0dp" | ||
| android:minHeight="?attr/actionBarSize" | ||
| android:paddingStart="4dp" |
Contributor
Author
There was a problem hiding this comment.
resolve rtl symmetry lint warning where the toolbar may not have symmetric spacing in right-to-left layouts
kiftio
commented
Aug 5, 2026
| <lint> | ||
| <!-- Branded navigation assets retain their vector detail at the sample's display size. --> | ||
| <issue id="VectorPath"> | ||
| <ignore path="src/main/res/drawable/home.xml" /> |
Contributor
Author
There was a problem hiding this comment.
the vector files are fairly large, can address separately
Assisted-By: devx/18f5006f-f46a-4c19-9f9e-7503f5a6c6ff
kiftio
force-pushed
the
08-05-setup_sample_lint_and_formatting
branch
from
August 5, 2026 11:00
6b9b36a to
1de829d
Compare
kiftio
marked this pull request as ready for review
August 5, 2026 11:00
Package Size
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Detekt and Android Lint static analysis have been extended to cover the
CheckoutKitAndroidDemosample app, in addition to the main library. This includes:detektplugin and configuration to the sample app'sbuild.gradle, using a newdetekt.config.ymlscoped to the samplewarningsAsErrors, dependency checking, and alint.xmlto suppress known false positives on branded vector assetslintReleaseanddetektagainst the sample appdev.ymlcommands (lint,format,check,detekt,android-lint) to also run against the sample app, with acheck_storefront_envguardandroid.net.Uri.parsewithandroidx.core.net.toUriinAuthenticationHelper, moving the hero image todrawable-nodpi, removing unused launcher PNG assets, and removing unused string resources and importsHow to test
dev android lintand confirm it passes for both the library and the sample appdev android check detektand confirm detekt runs against both targetsdev android formatand confirm auto-correct applies to both targetsandroid-testCI workflow and confirm the newSample static analysis and Android Lintstep passesBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.