Skip to content

Create a new UI component for DevSessions #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isaacroldan merged 2 commits into from
Jan 30, 2025
Merged

Create a new UI component for DevSessions #5320

isaacroldan merged 2 commits into from
Jan 30, 2025

Conversation

@isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 30, 2025 •
edited
Loading

WHY are these changes introduced?

The current UI component was getting too complex to support both legacy and new dev, with many conditionals and adding more props.

This PR aims to solve that by creating a simpler UI component specific for dev-sessions. So that we can keep evolving this one without affecting the current dev behaviour.

WHAT is this pull request doing?

  • Creates a new DevSessionUI component
  • Has the same shortcuts support as the old component
  • Can receive status updates via an injected devSessionStatusManager.

How to test your changes?

Nothing to test, this component is not being used yet (will be in a following PR)

Measuring impact

  • Existing analytics will cater for this addition (via cmd_dev_preview_url_opened and cmd_dev_graphiql_opened metrics)

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@isaacroldan Graphite App
Copy link
Contributor Author

isaacroldan commented Jan 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan marked this pull request as ready for review January 30, 2025 11:48
@isaacroldan isaacroldan requested a review from a team as a code owner January 30, 2025 11:48
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
75.48% (+0.04% 🔼)
 9002/11926
🟡 Branches
70.67% (+0.06% 🔼)
 4393/6216
🟡 Functions
75.31% (+0.01% 🔼)
 2364/3139
🟡 Lines
76% (+0.06% 🔼)
 8504/11190
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / DevSessionUI.tsx
 86.36% 80.56% 78.57% 90%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
95.18% (-1.2% 🔻)
86.49% (-2.7% 🔻)
 95.45% 100%

Test suite run success

2033 tests passing in 909 suites.

Report generated by 🧪jest coverage report action from 008b94c

@isaacroldan isaacroldan force-pushed the 01-30-create_a_new_ui_component_for_devsessions branch from 91b4d5e to 8f57848 Compare January 30, 2025 11:51
@isaacroldan isaacroldan force-pushed the 01-30-create_a_new_ui_component_for_devsessions branch from 8f57848 to 34a6555 Compare January 30, 2025 11:54
This was referenced Jan 30, 2025
Merged
Merged
Merged
@isaacroldan isaacroldan added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 2f165b5 Jan 30, 2025
1 check passed
@isaacroldan isaacroldan deleted the 01-30-create_a_new_ui_component_for_devsessions branch January 30, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigmichaelmartin craigmichaelmartin craigmichaelmartin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacroldan @craigmichaelmartin