Skip to content

Conversation

@isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 30, 2025

WHY are these changes introduced?

Building on the previous PR, this one starts using the new UI component for Dev sessions.

WHAT is this pull request doing?

  • Update ui.tsx to render the new component when using dev-sessions.
  • Abort operations have been extracted from the component itself (the UI component should not make API requests)

How to test your changes?

  1. Start a dev-session with app managament shopify app dev
  2. Verify that the new UI appears (you should see logs about the dev-session and more pastel colors)
  3. Do the same with a normal dev
  4. Verify that the old UI appears (no dev-session logs, bright colors)

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Jan 30, 2025

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.5% (+0.02% 🔼)
9008/11931
🟡 Branches
70.7% (+0.03% 🔼)
4396/6218
🟡 Functions
75.32% (+0.01% 🔼)
2365/3140
🟡 Lines
76.02% (+0.02% 🔼)
8510/11195

Test suite run success

2035 tests passing in 909 suites.

Report generated by 🧪jest coverage report action from 72d196c

@isaacroldan isaacroldan marked this pull request as ready for review January 30, 2025 13:14
@isaacroldan isaacroldan requested a review from a team as a code owner January 30, 2025 13:14
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@craigmichaelmartin
Copy link
Contributor

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @craigmichaelmartin! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/cli@0.0.0-snapshot-20250130135132

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Base automatically changed from 01-30-create_a_new_ui_component_for_devsessions to main January 30, 2025 15:27
@isaacroldan isaacroldan added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@isaacroldan isaacroldan added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 70f3a8a Jan 30, 2025
1 check passed
@isaacroldan isaacroldan deleted the 01-30-use_the_new_devsessionui_for_dev_sessions branch January 30, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants