Faster unit tests

[gonzaloriestra]

WHY are these changes introduced?

Local unit test wall-clock time is ~67s, largely due to vitest overhead (fork pool, eager includeSource scanning, heavy setup imports) and unnecessary sleep/setTimeout delays scattered across tests.

WHAT is this pull request doing?

Reduces local unit test wall-clock time from 67s → 53s (21% faster).

With the improvements from both branches in the stack, CI time is reduced from ~10 min to less than 5 min (+50% faster).

Changes:

• Switch vitest pool from forks to threads — saves ~12s by avoiding per-file process spawning
• Remove includeSource config and extract the one in-source test into its own file — cuts ~90s off aggregate collect time
• Replace eager zod import in vitest setup with lazy constructor.name check — faster test bootstrap
• Use define in vite config for compile-time env vars (SHOPIFY_UNIT_TEST, FORCE_HYPERLINK, FORCE_COLOR)
• Replace vitest.workspace.json with test.projects in root vite.config.ts
• Reduce excessive sleep/setTimeout delays in tests (100ms → 10ms for waitForInputsToBeReady, sendInputAndWait, and various test timers)
• Remove setImmediate/clearImmediate from fakeTimers (not available in threads pool)

How to test your changes?

pnpm test:unit

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[gonzaloriestra]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Faster unit tests #7029 👈 (View in Graphite)
• Faster CI #7009
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟢	Statements	81.94%	14619/17842
🟡	Branches	74.39%	7253/9750
🟢	Functions	81.06%	3710/4577
🟢	Lines	82.34%	13820/16784

Test suite run success

3806 tests passing in 1462 suites.

Report generated by 🧪jest coverage report action from efa0833

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/rest-api-throttler.d.ts

@@ -13,6 +13,13 @@ export declare function throttle<T>(request: () => T): Promise<T>;
  * @param response - The response object.
  */
 export declare function updateApiCallLimitFromResponse(response: RestResponse): void;
+/**
+ * Extracts the retry delay in milliseconds from the response's  header.
+ *
+ * @param response - The response object.
+ * @returns The retry delay in milliseconds, or 0 if not present/invalid.
+ */
+export declare function extractRetryDelayMsFromResponse(response: RestResponse): number;
 /**
  * Retries an operation after a delay specified in the response headers.
  *
@@ -20,4 +27,11 @@ export declare function updateApiCallLimitFromResponse(response: RestResponse):
  * @param operation - The operation to retry.
  * @returns - The response of the operation.
  */
-export declare function delayAwareRetry(response: RestResponse, operation: () => Promise<RestResponse>): Promise<RestResponse>;
\ No newline at end of file
+export declare function delayAwareRetry(response: RestResponse, operation: () => Promise<RestResponse>): Promise<RestResponse>;
+/**
+ * Extracts the API call limit (used/total) from the response's  header.
+ *
+ * @param response - The response object.
+ * @returns A tuple of [used, limit], or undefined if the header is missing/invalid.
+ */
+export declare function extractApiCallLimitFromResponse(response: RestResponse): [number, number] | undefined;
\ No newline at end of file

packages/cli-kit/dist/public/node/themes/api.d.ts

@@ -5,7 +5,6 @@ export type ThemeParams = Partial<Pick<Theme, 'name' | 'role' | 'processing' | '
 export type AssetParams = Pick<ThemeAsset, 'key'> & Partial<Pick<ThemeAsset, 'value' | 'attachment'>>;
 export declare function fetchTheme(id: number, session: AdminSession): Promise<Theme | undefined>;
 export declare function fetchThemes(session: AdminSession): Promise<Theme[]>;
-export declare function findDevelopmentThemeByName(name: string, session: AdminSession): Promise<Theme | undefined>;
 export declare function themeCreate(params: ThemeParams, session: AdminSession): Promise<Theme | undefined>;
 export declare function fetchThemeAssets(id: number, filenames: Key[], session: AdminSession): Promise<ThemeAsset[]>;
 export declare function deleteThemeAssets(id: number, filenames: Key[], session: AdminSession): Promise<Result[]>;

packages/cli-kit/dist/public/node/themes/theme-manager.d.ts

@@ -8,8 +8,8 @@ export declare abstract class ThemeManager {
     protected abstract removeTheme(): void;
     protected abstract context: string;
     constructor(adminSession: AdminSession);
-    findOrCreate(name?: string, role?: Role): Promise<Theme>;
-    fetch(name?: string, role?: Role): Promise<Theme | undefined>;
+    findOrCreate(): Promise<Theme>;
+    fetch(): Promise<Theme | undefined>;
     generateThemeName(context: string): string;
     create(themeRole?: Role, themeName?: string): Promise<Theme>;
 }
\ No newline at end of file

[graygilmore]

Love it

[aswamy]

Love these kind of fixes ❤️ Thank you!