Skip to content

Faster unit tests #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 9 commits into from
Mar 18, 2026
+605 −617
Merged

Faster unit tests #7029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c5806c
Baseline: 67.45s wall clock, 505s collect, 64.5s tests, 393 files, 37…
gonzaloriestra Mar 16, 2026
149db5e
Switch pool from forks to threads — 55.56s (−18% from 67.45s baseline…
gonzaloriestra Mar 16, 2026
01fb082
Extract in-source test + remove includeSource — 54.01s (−20% from bas…
gonzaloriestra Mar 16, 2026
b62337a
Reduce test delays: waitForInputsToBeReady 100→10ms, sendInputAndWait…
gonzaloriestra Mar 16, 2026
fe1f7ad
Reduce more setTimeout delays in app-event-watcher, file-watcher, ui,…
gonzaloriestra Mar 16, 2026
f3bd396
Reduce Dev.test.tsx sleep(0.1) to sleep(0.03) — 53.52s, tests_s 48.87…
gonzaloriestra Mar 16, 2026
dd436a3
Last step
gonzaloriestra Mar 17, 2026
59f3830
Fix CI
gonzaloriestra Mar 17, 2026
efa0833
Revert Zod change
gonzaloriestra Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions configurations/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ interface ConfigOptions {
poolStrategy: 'threads' | 'forks'
}

export default function config(packagePath: string, {poolStrategy}: ConfigOptions = {poolStrategy: 'forks'}) {
export default function config(packagePath: string, {poolStrategy}: ConfigOptions = {poolStrategy: 'threads'}) {
// always treat environment as one that doesn't support hyperlinks -- otherwise assertions are hard to keep consistent
process.env.FORCE_HYPERLINK = '0'
process.env.FORCE_COLOR = '1'
Expand All @@ -28,6 +28,11 @@ export default function config(packagePath: string, {poolStrategy}: ConfigOption
}

return defineConfig({
define: {
'process.env.SHOPIFY_UNIT_TEST': '"1"',
'process.env.FORCE_HYPERLINK': '"0"',
'process.env.FORCE_COLOR': '"1"',
},
resolve: {
alias: aliases(packagePath) as AliasOptions,
},
Expand All @@ -45,10 +50,6 @@ export default function config(packagePath: string, {poolStrategy}: ConfigOption
reporter: ['text', 'json', 'lcov'],
exclude: ['**/src/**/vendor/**'],
},
snapshotFormat: {
escapeString: true,
},
includeSource: ['**/src/**/*.{ts,tsx}'],
sequence: {
hooks: 'list',
},
Expand All @@ -58,8 +59,6 @@ export default function config(packagePath: string, {poolStrategy}: ConfigOption
'clearTimeout',
'setInterval',
'clearInterval',
'setImmediate',
'clearImmediate',
'Date',
],
},
Expand Down
214 changes: 107 additions & 107 deletions packages/app/src/cli/services/app-logs/logs-command/ui/components/Logs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,29 +124,29 @@ describe('Logs', () => {
const lastFrame = renderInstance.lastFrame()

expect(unstyled(lastFrame!)).toMatchInlineSnapshot(`
"2024-06-18 16:02:04.868 my-store my-function Success export \\"run\\" executed in 0.5124M instructions
test logs
"2024-06-18 16:02:04.868 my-store my-function Success export "run" executed in 0.5124M instructions
test logs

Input Query Variables:
Input Query Variables:

Namespace: inputQueryVariablesMetafieldNamespace
Key: inputQueryVariablesMetafieldKey
Namespace: inputQueryVariablesMetafieldNamespace
Key: inputQueryVariablesMetafieldKey

{
\\"key\\": \\"value\\"
}
{
"key": "value"
}

Input (10 bytes):
Input (10 bytes):

{
\\"test\\": \\"input\\"
}
{
"test": "input"
}

Output (10 bytes):
Output (10 bytes):

{
\\"test\\": \\"output\\"
}"
{
"test": "output"
}"
`)

renderInstance.unmount()
Expand Down Expand Up @@ -174,7 +174,7 @@ describe('Logs', () => {
const lastFrame = renderInstance.lastFrame()

expect(unstyled(lastFrame!)).toMatchInlineSnapshot(`
"2024-06-18 16:02:04.868 my-store my-function Success export \\"run\\" executed in 0.5124M instructions
"2024-06-18 16:02:04.868 my-store my-function Success export "run" executed in 0.5124M instructions
test logs

Input Query Variables:
Expand All @@ -187,15 +187,15 @@ describe('Logs', () => {
Input (10 bytes):

{
\\"test\\": \\"input\\"
"test": "input"
}

Output (10 bytes):

{
\\"test\\": \\"output\\"
"test": "output"
}"
`)
`)

renderInstance.unmount()
})
Expand Down Expand Up @@ -225,20 +225,20 @@ describe('Logs', () => {
const lastFrame = renderInstance.lastFrame()

expect(unstyled(lastFrame!)).toMatchInlineSnapshot(`
"2024-06-18 16:02:04.868 my-store my-function Success export \\"run\\" executed in 0.5124M instructions
test logs
"2024-06-18 16:02:04.868 my-store my-function Success export "run" executed in 0.5124M instructions
test logs

Input (10 bytes):
Input (10 bytes):

{
\\"test\\": \\"input\\"
}
{
"test": "input"
}

Output (10 bytes):
Output (10 bytes):

{
\\"test\\": \\"output\\"
}"
{
"test": "output"
}"
`)

renderInstance.unmount()
Expand Down Expand Up @@ -280,27 +280,27 @@ describe('Logs', () => {
const lastFrame = renderInstance.lastFrame()

expect(unstyled(lastFrame!)).toMatchInlineSnapshot(`
"2024-06-18 16:02:04.868 my-store my-function Success network access response from cache
Cache write time: 2023-05-12T15:17:01.000Z
Cache TTL: 300 s
HTTP request:
{
\\"url\\": \\"https://api.example.com/hello\\",
\\"method\\": \\"GET\\",
\\"headers\\": {},
\\"body\\": null,
\\"policy\\": {
\\"read_timeout_ms\\": 500
}
}
HTTP response:
{
\\"status\\": 200,
\\"body\\": \\"Success\\",
\\"headers\\": {
\\"header1\\": \\"value1\\"
"2024-06-18 16:02:04.868 my-store my-function Success network access response from cache
Cache write time: 2023-05-12T15:17:01.000Z
Cache TTL: 300 s
HTTP request:
{
"url": "https://api.example.com/hello",
"method": "GET",
"headers": {},
"body": null,
"policy": {
"read_timeout_ms": 500
}
}
}"
HTTP response:
{
"status": 200,
"body": "Success",
"headers": {
"header1": "value1"
}
}"
`)

renderInstance.unmount()
Expand Down Expand Up @@ -342,28 +342,28 @@ describe('Logs', () => {
const lastFrame = renderInstance.lastFrame()

expect(unstyled(lastFrame!)).toMatchInlineSnapshot(`
"2024-06-18 16:02:04.868 my-store my-function Success network access request executed in 80 ms
Attempt: 1
Connect time: 40 ms
Write read time: 40 ms
HTTP request:
{
\\"url\\": \\"https://api.example.com/hello\\",
\\"method\\": \\"GET\\",
\\"headers\\": {},
\\"body\\": null,
\\"policy\\": {
\\"read_timeout_ms\\": 500
"2024-06-18 16:02:04.868 my-store my-function Success network access request executed in 80 ms
Attempt: 1
Connect time: 40 ms
Write read time: 40 ms
HTTP request:
{
"url": "https://api.example.com/hello",
"method": "GET",
"headers": {},
"body": null,
"policy": {
"read_timeout_ms": 500
}
}
}
HTTP response:
{
\\"status\\": 200,
\\"body\\": \\"Success\\",
\\"headers\\": {
\\"header1\\": \\"value1\\"
}
}"
HTTP response:
{
"status": 200,
"body": "Success",
"headers": {
"header1": "value1"
}
}"
`)

renderInstance.unmount()
Expand Down Expand Up @@ -405,19 +405,19 @@ describe('Logs', () => {
const lastFrame = renderInstance.lastFrame()

expect(unstyled(lastFrame!)).toMatchInlineSnapshot(`
"2024-06-18 16:02:04.868 my-store my-function Failure network access request executed
Attempt: 1
HTTP request:
{
\\"url\\": \\"https://api.example.com/hello\\",
\\"method\\": \\"GET\\",
\\"headers\\": {},
\\"body\\": null,
\\"policy\\": {
\\"read_timeout_ms\\": 500
"2024-06-18 16:02:04.868 my-store my-function Failure network access request executed
Attempt: 1
HTTP request:
{
"url": "https://api.example.com/hello",
"method": "GET",
"headers": {},
"body": null,
"policy": {
"read_timeout_ms": 500
}
}
}
Error: Timeout Error"
Error: Timeout Error"
`)

renderInstance.unmount()
Expand Down Expand Up @@ -455,18 +455,18 @@ describe('Logs', () => {
const lastFrame = renderInstance.lastFrame()

expect(unstyled(lastFrame!)).toMatchInlineSnapshot(`
"2024-06-18 16:02:04.868 my-store my-function Success network access request executing in background
Reason: No cached response available
HTTP request:
{
\\"url\\": \\"https://api.example.com/hello\\",
\\"method\\": \\"GET\\",
\\"headers\\": {},
\\"body\\": null,
\\"policy\\": {
\\"read_timeout_ms\\": 500
}
}"
"2024-06-18 16:02:04.868 my-store my-function Success network access request executing in background
Reason: No cached response available
HTTP request:
{
"url": "https://api.example.com/hello",
"method": "GET",
"headers": {},
"body": null,
"policy": {
"read_timeout_ms": 500
}
}"
`)

renderInstance.unmount()
Expand Down Expand Up @@ -504,18 +504,18 @@ describe('Logs', () => {
const lastFrame = renderInstance.lastFrame()

expect(unstyled(lastFrame!)).toMatchInlineSnapshot(`
"2024-06-18 16:02:04.868 my-store my-function Success network access request executing in background
Reason: Cache is about to expire
HTTP request:
{
\\"url\\": \\"https://api.example.com/hello\\",
\\"method\\": \\"GET\\",
\\"headers\\": {},
\\"body\\": null,
\\"policy\\": {
\\"read_timeout_ms\\": 500
}
}"
"2024-06-18 16:02:04.868 my-store my-function Success network access request executing in background
Reason: Cache is about to expire
HTTP request:
{
"url": "https://api.example.com/hello",
"method": "GET",
"headers": {},
"body": null,
"policy": {
"read_timeout_ms": 500
}
}"
`)

renderInstance.unmount()
Expand Down
Loading
Loading