Skip to content

Show Local URL in dev info when no App URL is available#7541

Merged
isaacroldan merged 1 commit into
mainfrom
05-13-show_local_url_in_dev_info_when_no_app_url_is_available
May 13, 2026
Merged

Show Local URL in dev info when no App URL is available#7541
isaacroldan merged 1 commit into
mainfrom
05-13-show_local_url_in_dev_info_when_no_app_url_is_available

Conversation

@isaacroldan

@isaacroldan isaacroldan commented May 13, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

When running dev, the App info tab showed only the public App URL. For setups where no public App URL is available (e.g. extension-only apps), there was no way to see the URL used to serve the local extensions.

WHAT is this pull request doing?

  • Adds localURL (the proxy URL from network config) through dev.tsrenderDevDevSessionUI.
  • In the App info tab, shows App URL when available, otherwise falls back to Local URL. The two are mutually exclusive — never both.
  • Adds tests covering each branch of the fallback.

How to test your changes?

  1. Run dev against an app/config where the public App URL is set → App info tab shows App URL: only.
  2. Run dev in a setup without a public App URL → App info tab shows Local URL: only.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label May 13, 2026
@isaacroldan isaacroldan marked this pull request as ready for review May 13, 2026 09:20
@isaacroldan isaacroldan requested a review from a team as a code owner May 13, 2026 09:20
Copilot AI review requested due to automatic review settings May 13, 2026 09:20
@isaacroldan isaacroldan requested a review from a team as a code owner May 13, 2026 09:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the dev interactive “App info” tab by surfacing a usable URL even when no public App URL is configured (e.g., extension-only apps), by falling back to the local proxy URL.

Changes:

  • Plumbs localURL (from config.network.proxyUrl) through dev.tsrenderDevDevSessionUI.
  • Updates the App info tab to show App URL when present, otherwise show Local URL (mutually exclusive).
  • Adds unit tests covering both branches of the App URL vs Local URL rendering logic.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/app/src/cli/services/dev/ui/components/DevSessionUI.tsx Adds localURL prop and renders “Local URL” only when no appURL is provided.
packages/app/src/cli/services/dev/ui/components/DevSessionUI.test.tsx Adds coverage to ensure Local URL is hidden when App URL exists, and shown when App URL is absent.
packages/app/src/cli/services/dev/ui.tsx Threads the optional localURL through renderDev into DevSessionUI.
packages/app/src/cli/services/dev.ts Sources localURL from config.network.proxyUrl when launching dev UI.
.changeset/dev-local-url-fallback.md Adds a patch changeset documenting the user-facing change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@isaacroldan isaacroldan force-pushed the 05-13-show_local_url_in_dev_info_when_no_app_url_is_available branch from fe048cc to e4ec92b Compare May 13, 2026 09:25
@isaacroldan isaacroldan added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit 9ea415f May 13, 2026
71 of 77 checks passed
@isaacroldan isaacroldan deleted the 05-13-show_local_url_in_dev_info_when_no_app_url_is_available branch May 13, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants