Skip to content

Clarify filesystem testing guidance#7905

Merged
alfonso-noriega merged 1 commit into
mainfrom
06-23-clarify_filesystem_testing_guidance
Jul 6, 2026
Merged

Clarify filesystem testing guidance#7905
alfonso-noriega merged 1 commit into
mainfrom
06-23-clarify_filesystem_testing_guidance

Conversation

@alfonso-noriega

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

No issue; small documentation maintenance.

The filesystem testing guidance had an awkward sentence that could be read as recommending the opposite of the intended approach.

WHAT is this pull request doing?

Clarifies the testing strategy docs to recommend using temporary directories for filesystem I/O tests instead of stubbing the filesystem.

How to test your changes?

  • git diff --check

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Assisted-By: devx/35aa2b43-cb40-4048-859c-af48d6d3ca28
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner June 23, 2026 14:13
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 23, 2026
@alfonso-noriega alfonso-noriega added this pull request to the merge queue Jul 6, 2026
Merged via the queue into main with commit 9d5b46d Jul 6, 2026
29 checks passed
@alfonso-noriega alfonso-noriega deleted the 06-23-clarify_filesystem_testing_guidance branch July 6, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants