Skip to content

Remove did-you-mean lint suppression#8042

Merged
alfonso-noriega merged 1 commit into
mainfrom
maintenance/did-you-mean-cleanup-0709
Jul 10, 2026
Merged

Remove did-you-mean lint suppression#8042
alfonso-noriega merged 1 commit into
mainfrom
maintenance/did-you-mean-cleanup-0709

Conversation

@alfonso-noriega

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

No issue.

The did-you-mean command scoring helper carried a lint suppression for an unnecessary type assertion. This is small maintenance debt in a plugin hook that runs when commands are mistyped.

WHAT is this pull request doing?

Replace the ad-hoc object counter with a Map<string, number> counter so repeated bigrams are counted without non-null assertions or lint disables.

Behavior is unchanged: suggestions are still ranked by shared bigram count, then by shorter command name.

How to test your changes?

  • pnpm nx run plugin-did-you-mean:lint --skip-nx-cache
  • pnpm --dir packages/plugin-did-you-mean vitest run src/index.test.ts

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Not user-facing; no changeset needed.

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 9, 2026 12:57
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 9, 2026
@alfonso-noriega alfonso-noriega added this pull request to the merge queue Jul 10, 2026
Merged via the queue into main with commit 7610a67 Jul 10, 2026
29 of 30 checks passed
@alfonso-noriega alfonso-noriega deleted the maintenance/did-you-mean-cleanup-0709 branch July 10, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants