Skip to content

[Tests] Add unit tests for theme utility functions#8161

Merged
gonzaloriestra merged 1 commit into
mainfrom
tests-theme-utils-coverage-13360874357651607401
Jul 23, 2026
Merged

[Tests] Add unit tests for theme utility functions#8161
gonzaloriestra merged 1 commit into
mainfrom
tests-theme-utils-coverage-13360874357651607401

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

These changes are introduced to cover the theme utility functions under packages/cli-kit/src/public/node/themes/utils.ts and ensure their behavior is robust and verified against regressions.

WHAT is this pull request doing?

This pull request introduces comprehensive unit tests in packages/cli-kit/src/public/node/themes/utils.test.ts for:

  • isDevelopmentTheme
  • composeThemeGid
  • parseGid
  • promptThemeName (by mocking its dependencies)

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 13360874357651607401 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 23, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label Jul 23, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review July 23, 2026 09:44
@gonzaloriestra
gonzaloriestra requested review from a team as code owners July 23, 2026 09:44

gonzaloriestra commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 23, 2:14 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 23, 2:15 PM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Jul 23, 2026
Merged via the queue into main with commit de7329a Jul 23, 2026
31 checks passed
@gonzaloriestra
gonzaloriestra deleted the tests-theme-utils-coverage-13360874357651607401 branch July 23, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants