Remove obsolete app startup hook - #8247
Merged
Merged
Conversation
Assisted-By: devx/0c1eb67d-70ce-4605-a45a-e26ce9fe783f
Assisted-By: devx/0c1eb67d-70ce-4605-a45a-e26ce9fe783f
alfonso-noriega
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every CLI command runs the app init hook, including commands that do not use app code. The hook clears a disk-backed command cache and sets
COMMAND_RUN_ID.The cache was intended to pass the selected TOML file from the app prompt to config linking. It does not do that in the normal flow:
selectOrCreateApp()reads the cache beforeselectAppPrompt()populates it, so no selected TOML is stored. Config linking already scans the real TOML files and matches the selected app byclient_id.This means the hook adds global startup work without changing config selection. Signed-upload URL isolation is still required, so this change keeps it with a process-local UUID in the app client.
What
Testing