Skip to content

Remove obsolete app startup hook - #8247

Merged
isaacroldan merged 2 commits into
mainfrom
isaac/remove-obsolete-app-init-hook
Aug 4, 2026
Merged

Remove obsolete app startup hook#8247
isaacroldan merged 2 commits into
mainfrom
isaac/remove-obsolete-app-init-hook

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Why

Every CLI command runs the app init hook, including commands that do not use app code. The hook clears a disk-backed command cache and sets COMMAND_RUN_ID.

The cache was intended to pass the selected TOML file from the app prompt to config linking. It does not do that in the normal flow: selectOrCreateApp() reads the cache before selectAppPrompt() populates it, so no selected TOML is stored. Config linking already scans the real TOML files and matches the selected app by client_id.

This means the hook adds global startup work without changing config selection. Signed-upload URL isolation is still required, so this change keeps it with a process-local UUID in the app client.

What

  • Remove the global app init hook and obsolete command cache.
  • Scope signed-upload cache keys by app and CLI process.

Testing

  • 114 focused app tests
  • App and CLI lint and type-check
  • Knip and CLI bundle
  • Version and organization help smoke tests

Assisted-By: devx/0c1eb67d-70ce-4605-a45a-e26ce9fe783f
@isaacroldan
isaacroldan requested a review from a team as a code owner August 4, 2026 09:42
@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Aug 4, 2026
Assisted-By: devx/0c1eb67d-70ce-4605-a45a-e26ce9fe783f
@github-actions github-actions Bot added no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. and removed Area: @shopify/cli @shopify/cli package issues labels Aug 4, 2026
@isaacroldan
isaacroldan added this pull request to the merge queue Aug 4, 2026
Merged via the queue into main with commit e35f776 Aug 4, 2026
29 checks passed
@isaacroldan
isaacroldan deleted the isaac/remove-obsolete-app-init-hook branch August 4, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants